Make Rubocop happy

This commit is contained in:
Penar Musaraj 2019-07-29 21:32:27 -04:00
parent ce839a5d5c
commit e49eb3bd9f
2 changed files with 11 additions and 9 deletions

View File

@ -1,3 +1,5 @@
# frozen_string_literal: true
class MoveToManagedAuthenticator < ActiveRecord::Migration[5.2] class MoveToManagedAuthenticator < ActiveRecord::Migration[5.2]
def up def up
execute <<~SQL execute <<~SQL

View File

@ -33,11 +33,11 @@ describe OAuth2BasicAuthenticator do
let(:authenticator) { OAuth2BasicAuthenticator.new } let(:authenticator) { OAuth2BasicAuthenticator.new }
let(:auth) do let(:auth) do
OmniAuth::AuthHash.new({ 'provider' => 'oauth2_basic', OmniAuth::AuthHash.new('provider' => 'oauth2_basic',
'credentials' => { 'token': 'token' }, 'credentials' => { 'token': 'token' },
'uid' => '123456789', 'uid' => '123456789',
'info' => { id: 'id' }, 'info' => { id: 'id' },
'extra' => {} }) 'extra' => {})
end end
before(:each) do before(:each) do
@ -79,14 +79,14 @@ describe OAuth2BasicAuthenticator do
result = authenticator.after_authenticate(auth) result = authenticator.after_authenticate(auth)
expect(result.email_valid).to eq(true) expect(result.email_valid).to eq(true)
end end
it 'doesnt validate user email if provider hasnt verified' do it 'doesnt validate user email if provider hasnt verified' do
SiteSetting.oauth2_email_verified = false SiteSetting.oauth2_email_verified = false
authenticator.stubs(:fetch_user_details).returns(email: user.email, email_verified: nil) authenticator.stubs(:fetch_user_details).returns(email: user.email, email_verified: nil)
result = authenticator.after_authenticate(auth) result = authenticator.after_authenticate(auth)
expect(result.email_valid).to eq(false) expect(result.email_valid).to eq(false)
end end
it 'doesnt affect the site setting' do it 'doesnt affect the site setting' do
SiteSetting.oauth2_email_verified = true SiteSetting.oauth2_email_verified = true
authenticator.stubs(:fetch_user_details).returns(email: user.email, email_verified: false) authenticator.stubs(:fetch_user_details).returns(email: user.email, email_verified: false)
@ -235,7 +235,7 @@ describe OAuth2BasicAuthenticator do
let(:authenticator) { OAuth2BasicAuthenticator.new } let(:authenticator) { OAuth2BasicAuthenticator.new }
let(:auth) do let(:auth) do
OmniAuth::AuthHash.new({ OmniAuth::AuthHash.new(
'provider' => 'oauth2_basic', 'provider' => 'oauth2_basic',
'credentials' => { 'credentials' => {
'token' => 'token' 'token' => 'token'
@ -246,7 +246,7 @@ describe OAuth2BasicAuthenticator do
"email" => 'sammy@digitalocean.com' "email" => 'sammy@digitalocean.com'
}, },
'extra' => {} 'extra' => {}
}) )
end end
let(:access_token) do let(:access_token) do