FEATURE: Respect the email_verified boolean when supplied by IDP
This commit is contained in:
parent
3e83fa9c50
commit
67a5595e98
|
@ -16,6 +16,12 @@ class OpenIDConnectAuthenticator < Auth::ManagedAuthenticator
|
||||||
SiteSetting.openid_connect_enabled
|
SiteSetting.openid_connect_enabled
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def primary_email_verified?(auth)
|
||||||
|
supplied_verified_boolean = auth['extra']['raw_info']['email_verified']
|
||||||
|
# If the payload includes the email_verified boolean, use it. Otherwise assume true
|
||||||
|
supplied_verified_boolean.nil? ? true : supplied_verified_boolean
|
||||||
|
end
|
||||||
|
|
||||||
def register_middleware(omniauth)
|
def register_middleware(omniauth)
|
||||||
|
|
||||||
omniauth.provider :openid_connect,
|
omniauth.provider :openid_connect,
|
||||||
|
|
|
@ -0,0 +1,50 @@
|
||||||
|
# frozen_string_literal: true
|
||||||
|
|
||||||
|
require 'rails_helper'
|
||||||
|
require_relative '../../lib/omniauth_open_id_connect'
|
||||||
|
|
||||||
|
describe OpenIDConnectAuthenticator do
|
||||||
|
let(:authenticator) { described_class.new }
|
||||||
|
let(:user) { Fabricate(:user) }
|
||||||
|
let(:hash) { OmniAuth::AuthHash.new(
|
||||||
|
provider: "oidc",
|
||||||
|
uid: "123456789",
|
||||||
|
info: {
|
||||||
|
name: "John Doe",
|
||||||
|
email: user.email
|
||||||
|
},
|
||||||
|
extra: {
|
||||||
|
raw_info: {
|
||||||
|
email: user.email,
|
||||||
|
name: "John Doe"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
)}
|
||||||
|
|
||||||
|
context "when email_verified is not supplied" do
|
||||||
|
# Some IDPs do not supply this information
|
||||||
|
# In this case we trust that they have verified the address
|
||||||
|
it 'matches the user' do
|
||||||
|
result = authenticator.after_authenticate(hash)
|
||||||
|
|
||||||
|
expect(result.user).to eq(user)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context "when email_verified is true" do
|
||||||
|
it 'matches the user' do
|
||||||
|
hash[:extra][:raw_info][:email_verified] = true
|
||||||
|
result = authenticator.after_authenticate(hash)
|
||||||
|
expect(result.user).to eq(user)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context "when email_verified is false" do
|
||||||
|
it 'does not match the user' do
|
||||||
|
hash[:extra][:raw_info][:email_verified] = false
|
||||||
|
result = authenticator.after_authenticate(hash)
|
||||||
|
expect(result.user).to eq(nil)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
end
|
Loading…
Reference in New Issue