From 4cdc5c64d5d2814c373f0b96bd2e6e5ba003b489 Mon Sep 17 00:00:00 2001
From: "zhanfeng.zeng" <zhanfeng.zeng@anker.io>
Date: Tue, 20 May 2025 10:04:30 +0800
Subject: [PATCH] FIX: Correct spec execution error.

---
 spec/requests/answer_controller_spec.rb | 46 ++++++++++++-------------
 1 file changed, 22 insertions(+), 24 deletions(-)

diff --git a/spec/requests/answer_controller_spec.rb b/spec/requests/answer_controller_spec.rb
index 534e81d..21b02e5 100644
--- a/spec/requests/answer_controller_spec.rb
+++ b/spec/requests/answer_controller_spec.rb
@@ -51,31 +51,29 @@ describe DiscourseSolved::AnswerController do
     end
 
     context "with plugin modifier" do
-      it "allows plugins to bypass rate limiting" do
-        sign_in(user)
-
-        # Register a modifier that disables rate limiting
-        plugin_instance = DiscoursePluginRegistry.new
-        DiscoursePluginRegistry.register_modifier(
-          plugin_instance,
-          :solved_answers_controller_run_rate_limiter
-        ) do |_, _|
-          false
-        end
-
-        # Multiple requests should succeed without rate limiting
-        post "/solution/accept.json", params: { id: solution_post.id }
-        expect(response.status).to eq(200)
-
-        post "/solution/accept.json", params: { id: solution_post.id }
-        expect(response.status).to eq(200)
-
-        # Clean up
-        DiscoursePluginRegistry.unregister_modifier(:solved_answers_controller_run_rate_limiter)
-      end
-    end
+     it "allows plugins to bypass rate limiting" do
+       sign_in(user)
+       # Store the block in a variable so we can reference it for unregistration
+       block = ->(_, _) { false }
+       # Register modifier with proper parameters - plugin instance (self) and name
+       DiscoursePluginRegistry.register_modifier(
+         self,
+         :solved_answers_controller_run_rate_limiter,
+         &block
+       )
+       post "/solution/accept.json", params: { id: solution_post.id }
+       expect(response.status).to eq(200)
+       post "/solution/accept.json", params: { id: solution_post.id }
+       expect(response.status).to eq(200)
+       # Unregister with the same plugin instance and block
+       DiscoursePluginRegistry.unregister_modifier(
+         self, # plugin_instance parameter
+         :solved_answers_controller_run_rate_limiter, # name parameter
+         &block # same block used for registration
+       )
+     end
+   end
   end
-
   describe "#unaccept" do
     before do
       # Setup an accepted solution