Clean up N+1 queries

app/controllers/discourse_feature_voting/votes_controller.rb

@@ -93,19 +93,13 @@ module DiscourseFeatureVoting
 		end
 
 		def who_voted(topic)
-			users = []
+			users = User.find(UserCustomField.where(name: "votes", value: topic.id).pluck(:user_id))
-			User.where(id: topic.who_voted).each do |user|
+			ActiveModel::ArraySerializer.new(users, scope: Guardian.new(User.find_by(id: params["user_id"])), each_serializer: UserSerializer)
-				users.push(UserSerializer.new(user, scope: guardian, root: 'user'))
-			end
-			return users
 		end
 
 		def who_super_voted(topic)
-			users = []
+			users = User.find(UserCustomField.where(name: "super_votes", value: topic.id).pluck(:user_id))
-			User.where(id: topic.who_voted).each do |user|
+			ActiveModel::ArraySerializer.new(users, scope: Guardian.new(User.find_by(id: params["user_id"])), each_serializer: UserSerializer)
-				users.push(UserSerializer.new(user, scope: guardian, root: 'user'))
-			end
-			return users
 		end
 	end
 end

assets/javascripts/discourse/widgets/vote-count.js.es6

@@ -86,8 +86,8 @@ export default createWidget('vote-count', {
 });
 
 function whoVotedAvatars(user) {
-  return { template: user.user.avatar_template,
+  return { template: user.avatar_template,
-           username: user.user.username,
+           username: user.username,
-           post_url: user.user.post_url,
+           post_url: user.post_url,
-           url: Discourse.getURL('/users/') + user.user.username.toLowerCase() };
+           url: Discourse.getURL('/users/') + user.username.toLowerCase() };
 }

plugin.rb

@@ -67,19 +67,13 @@ after_initialize do
     end
 
     def who_voted
-      users = []
+      users = User.find(UserCustomField.where(name: "votes", value: object.topic.id).pluck(:user_id))
-      User.where(id: object.topic.who_voted).each do |user|
+      ActiveModel::ArraySerializer.new(users, scope: scope, each_serializer: UserSerializer)
-        users.push(UserSerializer.new(user, scope: scope, root: 'user'))
-      end
-      return users
     end
 
     def who_super_voted
-      users = []
+      users = User.find(UserCustomField.where(name: "votes", value: object.topic.id).pluck(:user_id))
-      User.where(id: object.topic.who_super_voted).each do |user|
+      ActiveModel::ArraySerializer.new(users, scope: scope, each_serializer: UserSerializer)
-        users.push(UserSerializer.new(user, scope: scope, root: 'user'))
-      end
-      return users
     end
   end