DEV: Return only valid repos

This will stop non-upgradeable plugins from showing up on the list. This mainly means core plugins like `poll` or `chat`

app/controllers/docker_manager/admin_controller.rb

@@ -21,20 +21,18 @@ module DockerManager
         result[:fork] = true if result[:official] &&
           !r.url.starts_with?("https://github.com/discourse/")
 
-        if r.valid?
-          result[:id] = r
-            .name
-            .downcase
-            .gsub(/[^a-z]/, "_")
-            .gsub(/_+/, "_")
-            .sub(/_$/, "")
-          result[:version] = r.latest_local_commit
-          result[:pretty_version] = r.latest_local_tag_version.presence
-          result[:url] = r.url
-          if r.upgrading?
-            result[:upgrading] = true
-            result[:version] = r.upgrade_version
-          end
+        result[:id] = r
+          .name
+          .downcase
+          .gsub(/[^a-z]/, "_")
+          .gsub(/_+/, "_")
+          .sub(/_$/, "")
+        result[:version] = r.latest_local_commit
+        result[:pretty_version] = r.latest_local_tag_version.presence
+        result[:url] = r.url
+        if r.upgrading?
+          result[:upgrading] = true
+          result[:version] = r.upgrade_version
         end
 
         result

lib/docker_manager/git_repo.rb

@@ -84,7 +84,8 @@ class DockerManager::GitRepo
 
     Discourse.visible_plugins.each do |p|
       next if p.name == "docker_manager"
-      repos << DockerManager::GitRepo.new(File.dirname(p.path), p.name)
+      repo = DockerManager::GitRepo.new(File.dirname(p.path), p.name)
+      repos << repo if repo.valid?
     end
 
     repos