gjs, helper invocation case, typos, latest license template, unnecessary tracking, concatClass, unnecessary service injection, new imports, whitespace, pure function helper, htmlSafe calling convention, this. in template, unused vars in ruby, update linting, qunit-dom
Git repositories will be initialized less often and then copied for each
spec. This reduces the calls to 'git' and the total execution time of
the specs.
Requesting /admin/docker/repos.json with a lot of plugins installed can
take a lot of time because of the large number of calls to the 'git'
CLI that are used to retrieve various information about the plugin
(eg. branch, latest commit, remote URL, etc).
This is not a problem in production because of memoization and the
much lower number of installed plugins, but it is a problem in test
environment where specs requesting this page can take 10+ seconds with
~100 installed plugins.
This commit speeds up by stubbing the `find_all` method to return only
the first few repositories.
This system spec is flaky and we are getting a blank page so I would
like to see what the HTML is. Previously printing of the page's HTML was
doing it too early such that the ember application has not even boot.
RSpec predicate matchers provide poor output when tests fail.
This commit switches to Capybara RSpec matches so that we get more
debugging information as to why these tests are flaky...
I'm unable to find why the tests are failing in the Discourse core repo's plugin tests workflow. These tests always pass in the plugin repo and my local dev environment.
This PR will refresh the software update page so that self-hosters can more easily understand the plugins they have installed and which plugins need updates, and so that they are able to quickly and easily update them (or update everything).
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
This introduces a fallback compatibility parser, identical to the one introduced in https://github.com/discourse/discourse/pull/22714
This will allow Docker Manager to parse new compatibility files, even when running on older Discourse instances. This is only intended as a temporary solution, and will be removed before the Discourse 3.2 release.
* FEATURE: Adds support for git tags
* Detects when the tracked branch has been deleted from `origin` and forces a rebuild on the command line
* Allows updating when a tag is tracked and the tag was moved to a new commit
* Improves support for shallow clones
* Works with partial clones
* Adds lots of specs for git commands and replaces the existing specs. All specs use real git repositories instead of mocks