Using `git rev-parse --short` will adapt the number of characters based on the number of commits in the repository. In a development checkout of Discourse, it'll currently output 10 characters, making the chance of a collision minuscule.
However, in production we use a shallow clone of the Discourse repository. That means that `git rev-parse --short` only outputs 8 characters. On the `main` branch (with almost 50k commits), we currently have 6 7-character collisions, and no 8-character collisions. However, when looking beyond the `main` branch, 8-character collisions [have been observed](https://meta.discourse.org/t/193320/3).
This commit updates docker_manager to use the full commit hash internally, and for GitHub comparison links. In the UI, hashes are truncated to 8 characters, and the full hash is displayed on mouseover.
docker_manager's implementation of `getURL` doesn't use the core
Discourse method so this might seem a little pointless, but it greatly
helps in our ability to grep the plugins so it's worth doing.
* Ember upgrade to 3.6.1
* ember-ajax printing deprecations; stop using it
* Use tag versions when possible instead of hashes
* Remove inline scripts for CSP
* dump `git describe` errors
* Commit hashes still needed for github diff link
* Update READMEs
* Production build
* Make repo-status component more isolated
* Minor tweaks
* Get JS tests in a working state, and write tests for repo-status component
* Add a note about tests in README
* Apply Prettier
* Production build #2
* We need vendor/message-bus.js
David Taylor
Osama Sayegh
Jarek Radosz
Robin Ward
Neil Lalonde
Arpit Jalan