docker-library
/
bashbrew
mirror of https://github.com/docker-library/bashbrew.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #88 from infosiftr/docker-push-on-index 

Fix fetchRegistryImageIds (which is only used for "docker push" no-op) to no longer return members of an index/manifest list
This commit is contained in:
Tianon Gravi 2023-12-01 10:57:06 -08:00 committed by GitHub
parent ff6b5f24ed 9a271ea747
commit 36b3473420
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/bashbrew/registry.go
View File

@ -28,6 +28,12 @@ func fetchRegistryImageIds(image string) []string {
return ids return ids
} }
ids := []string{}
if img.IsImageIndex() {
ids = append(ids, digest)
return ids // see note above -- this function is used for "docker push" which does not and cannot (currently) support a manifest list / image index
}
manifests, err := img.Manifests(ctx) manifests, err := img.Manifests(ctx)
if err != nil { if err != nil {
if debugFlag { if debugFlag {
@ -36,10 +42,8 @@ func fetchRegistryImageIds(image string) []string {
return nil return nil
} }
ids := []string{} // TODO balk if manifests has more than one entry in it
if img.IsImageIndex() {
ids = append(ids, digest)
}
for _, manifestDesc := range manifests { for _, manifestDesc := range manifests {
ids = append(ids, manifestDesc.Digest.String()) ids = append(ids, manifestDesc.Digest.String())
manifest, err := img.At(manifestDesc).Manifest(ctx) manifest, err := img.At(manifestDesc).Manifest(ctx)