docker-library
/
dockerfile-validator
mirror of https://github.com/docker-library/dockerfile-validator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use a better description for "build-essential" oh_no

This commit is contained in:
Tianon Gravi 2020-03-03 15:13:04 -08:00
parent f47b5137a1
commit a2fba9ed93
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dockerfile-validator
View File

@ -156,7 +156,7 @@ fi
if aptInstalls="$(grep -E '(^|[;|&])[[:space:]]*apt(-get)?[[:space:]]+(-[^[:space:]]*[[:space:]]+)*([a-z]+-)?install' <<<"$runs")" && [ -n "$aptInstalls" ]; then
if essential="$(grep 'build-essential' <<<"$aptInstalls")" && [ -n "$essential" ]; then
# TODO determine whether we're actually building Debian packages in this `RUN` line before we blanket complain about this
oh_no_context "'RUN apt-get install build-essential' seems to be in use!" \
oh_no_context "'RUN apt-get install build-essential' should be replaced by more specific dependencies such as 'make' and 'gcc' (unless building Debian packages)" \
'https://packages.debian.org/unstable/build-essential' \
'--' 'RUN' "$essential"
fi