docker-library
/
docs
mirror of https://github.com/docker-library/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2238 from infosiftr/neo4j-not-short 

Remove "neo4j" short tags special case
This commit is contained in:
yosifkit 2022-11-28 16:32:55 -08:00 committed by GitHub
parent 0de69101a0 a922faeafe
commit 0b2e75cc41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
push.pl
View File

@ -89,9 +89,7 @@ sub prompt_for_edit {
$proposedText =~ s%$supportedTagsRegex%$sponsoredLinks$1$2%; $proposedText =~ s%$supportedTagsRegex%$sponsoredLinks$1$2%;
} }
my $alwaysShortTags = ($proposedFile eq 'neo4j/README.md'); if ($lengthLimit > 0 && length($proposedText) > $lengthLimit) {
if ($alwaysShortTags || ($lengthLimit > 0 && length($proposedText) > $lengthLimit)) {
# TODO https://github.com/docker/hub-beta-feedback/issues/238 # TODO https://github.com/docker/hub-beta-feedback/issues/238
my $fullUrl = "$githubBase/$proposedFile"; my $fullUrl = "$githubBase/$proposedFile";
my $shortTags = "-\tSee [\"Supported tags and respective \`Dockerfile\` links\" at $fullUrl]($fullUrl#supported-tags-and-respective-dockerfile-links)\n\n"; my $shortTags = "-\tSee [\"Supported tags and respective \`Dockerfile\` links\" at $fullUrl]($fullUrl#supported-tags-and-respective-dockerfile-links)\n\n";
@ -100,16 +98,12 @@ sub prompt_for_edit {
my $startingNote = $genericNote . "\n\n"; my $startingNote = $genericNote . "\n\n";
my $endingNote = "\n\n...\n\n" . $genericNote; my $endingNote = "\n\n...\n\n" . $genericNote;
$tagsNote = $shortTags if $alwaysShortTags;
my $trimmedText = $proposedText; my $trimmedText = $proposedText;
# if our text is too long for the Hub length limit, let's first try removing the "Supported tags" list and add $tagsNote and see if that's enough to let us put the full image documentation # if our text is too long for the Hub length limit, let's first try removing the "Supported tags" list and add $tagsNote and see if that's enough to let us put the full image documentation
$trimmedText =~ s%$supportedTagsRegex%$sponsoredLinks$1$tagsNote%ms; $trimmedText =~ s%$supportedTagsRegex%$sponsoredLinks$1$tagsNote%ms;
# (we scrape until the next "h1" or a line starting with a link which is likely a build status badge for an architecture-namespace) # (we scrape until the next "h1" or a line starting with a link which is likely a build status badge for an architecture-namespace)
$proposedText = $trimmedText if $alwaysShortTags;
if (length($trimmedText) > $lengthLimit) { if (length($trimmedText) > $lengthLimit) {
# ... if that doesn't do the trick, then do our older naïve description trimming # ... if that doesn't do the trick, then do our older naïve description trimming
$trimmedText = $startingNote . substr $proposedText, 0, ($lengthLimit - length($startingNote . $endingNote)); $trimmedText = $startingNote . substr $proposedText, 0, ($lengthLimit - length($startingNote . $endingNote));