From d6c1f03ae0ff69df4155b1179851ffdd12741df6 Mon Sep 17 00:00:00 2001 From: Tianon Gravi Date: Thu, 19 Jul 2018 07:41:11 -0700 Subject: [PATCH] Try generating tag list before generating file (so that we don't create a README file with template placeholders in it) --- update.sh | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/update.sh b/update.sh index 9be0b20e7..3b2544453 100755 --- a/update.sh +++ b/update.sh @@ -113,6 +113,15 @@ for image in "${images[@]}"; do echo ' GIT PREFETCH => "'"$repo"'"' "$helperDir/git-prefetch.sh" "$repo" + if ! partial="$("$helperDir/generate-dockerfile-links-partial.sh" "$repo")"; then + { + echo + echo "WARNING: failed to fetch tags for '$repo'; skipping!" + echo + } >&2 + continue + fi + targetFile="$repo/README.md" { @@ -123,14 +132,6 @@ for image in "${images[@]}"; do } > "$targetFile" echo ' TAGS => generate-dockerfile-links-partial.sh "'"$repo"'"' - if ! partial="$("$helperDir/generate-dockerfile-links-partial.sh" "$repo")"; then - { - echo - echo "WARNING: failed to fetch tags for '$repo'; skipping!" - echo - } >&2 - continue - fi if [ -z "$partial" ]; then if [ -n "$ARCH_SPECIFIC_DOCS" ]; then partial='**No supported tags found!**'$'\n\n''It is very likely that `%%REPO%%` does not support the currently selected architecture (`'"$BASHBREW_ARCH"'`).'