From e3c442261658079cb2aefb736d23b35bab5480a1 Mon Sep 17 00:00:00 2001 From: Tianon Gravi Date: Wed, 12 Jun 2019 16:39:29 -0700 Subject: [PATCH] Remove "Dockerfile path" from tags listing For context, this was added initially because the previous rendering of Markdown on the Hub was such that code in a link would render without underline and barely noticeable blue color (and no hover behavior either besides the normal cursor change), so it wasn't clear it was even a link without additional non-code text. Now that that has been corrected/adjusted, I think it's totally reasonable to remove those (since they're included in the link already). For reference/comparison, this takes the `open-liberty` readme from ~39k characters down to ~33k characters. --- .template-helpers/generate-dockerfile-links-partial.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.template-helpers/generate-dockerfile-links-partial.tmpl b/.template-helpers/generate-dockerfile-links-partial.tmpl index 2d94be722..8b014de35 100644 --- a/.template-helpers/generate-dockerfile-links-partial.tmpl +++ b/.template-helpers/generate-dockerfile-links-partial.tmpl @@ -30,7 +30,7 @@ This template defines the "Supported tags and Dockerfile links" portion of an im {{- $dir := .ArchDirectory $arch -}} {{- $dockerfile := .ArchFile $arch -}} {{- $dockerfilePath := eq $dir "." | ternary $dockerfile (join "/" $dir $dockerfile) -}} - ` {{- $e.Tags | join "`, `" -}} ` (* {{- $dockerfilePath -}} *) + ` {{- $e.Tags | join "`, `" -}} ` {{- $gitCommit := $e.ArchGitCommit $arch -}} {{- if $isGitHub -}} ]( {{- $repoUrlBase -}} /blob/ {{- $gitCommit -}} / {{- $dockerfilePath -}} ) {{- end -}} {{- /* TODO decide what to do (if anything) about non-GitHub repos with respect to URL */ -}} @@ -63,7 +63,7 @@ This template defines the "Supported tags and Dockerfile links" portion of an im {{- $dir := .ArchDirectory $arch -}} {{- $dockerfile := .ArchFile $arch -}} {{- $dockerfilePath := eq $dir "." | ternary $dockerfile (join "/" $dir $dockerfile) -}} - ` {{- $e.Tags | first -}} ` (* {{- $dockerfilePath -}} *) + ` {{- $e.Tags | first -}} ` {{- $gitCommit := $e.ArchGitCommit $arch -}} {{- if $isGitHub -}} ]( {{- $repoUrlBase -}} /blob/ {{- $gitCommit -}} / {{- $dockerfilePath -}} ) {{- end -}} {{- /* TODO decide what to do (if anything) about non-GitHub repos with respect to URL */ -}}