Commit Graph

42 Commits

Author SHA1 Message Date
Tianon Gravi 5eaf242326 Adjust diff-pr.sh to no longer tolerate "bashbrew cat" failures (since we handle "new" and "deleted" images as special cases now) 2020-12-03 09:53:07 -08:00
Tianon Gravi 7e6ffbece8 Update diff-pr to scrape COPY from flattened Dockerfile so "COPY \\n foo \\n bar \\n baz" doesn't trip us up 2020-05-15 16:25:07 -07:00
Tianon Gravi 91d0285431 Move ~sorted "bashbrew cat" clone into a separate file for easier use externally 2020-05-11 07:36:40 -07:00
Tianon Gravi 9142251d50 Also update "diff-pr.sh" to be more friendly on "new-image" PRs 2020-05-07 21:51:20 -07:00
Tianon Gravi f27f59f5f8 Replace "_bashbrew-arches" and "_bashbrew-shared-tags" with a ~sorted "bashbrew cat" clone in diff-pr.sh 2020-05-07 21:28:27 -07:00
Tianon Gravi 563211d8c8 Fix "diff-pr" with multiple images 😅 2020-05-07 08:47:05 -07:00
Tianon Gravi 39cc4e2159 Add initial GitHub Actions CI 2020-05-05 11:38:15 -07:00
Joe Ferguson 529fe93da0 Fix diff-pr tar error on empty file
> tar: This does not look like a tar archive
2020-04-27 13:29:41 -07:00
Tianon Gravi 4863820eea Adjust "diff-pr.sh" to be more explicit about failure in certain scenarios (hopefully improves debuggability) 2019-07-31 13:57:17 -07:00
Tianon Gravi 4b4a88f075 Adjust "diff-pr.sh" to ignore "COPY --from=" (since it cannot reasonably access files from the referenced image/stage context) 2019-07-31 13:52:27 -07:00
Tianon Gravi c3aa695e2c Adjust "diff-pr" to be more specific about "Dockerfile.builder" explicitly (to cut down on false-positives) 2019-06-25 10:59:53 -07:00
Tianon Gravi e1a94ef563 Update "diff-pr.sh" to use the new DockerFroms function 2019-06-12 08:06:45 -07:00
Tianon Gravi de13dd5bb7 Replace "--ignore-all-space" with "--ignore-blank-lines", "--ignore-space-at-eol", and "--ignore-space-change"
See https://github.com/docker-library/official-images/pull/5859#issuecomment-489819055
2019-05-07 16:25:01 -07:00
Tianon Gravi 8df2fd5d54 Fix "diff-pr.sh" edge case 2019-04-19 13:21:45 -07:00
Tianon Gravi b1f25a69e4 Add ".dockerignore" to the list of things "diff-pr" optionally looks at 2019-04-17 14:51:14 -07:00
Tianon Gravi 48c82ce313 Fix diff-pr globbing on images that do "COPY ./..." (like neo4j) 2019-04-09 15:37:46 -07:00
Tianon Gravi de3335b278 Fix minor edge case in diff-pr 2019-03-21 15:55:12 -07:00
Tianon Gravi 510aeda20f Use "find" instead of "eval" for more defensive glob expansion 2019-03-07 15:54:05 -08:00
Tianon Gravi 413b9689b5 Update "diff-pr.sh" to ignore "--chown=" on COPY/ADD 2018-11-20 14:10:37 -08:00
Tianon Gravi 087cef7a9f Add support for "File:" in manifest files
See https://github.com/docker-library/go-dockerlibrary/pull/16 for format implementation details.
2018-10-22 16:06:21 -07:00
Tianon Gravi 667443bb39 Revert "breaks-rewrites" addition to diff-pr -- it causes more issues generally than it helps 2018-10-15 12:50:34 -07:00
Tianon Gravi 733d0bfaef Add explicit "--break-rewrites" value to fix overaggressive splitting 2018-10-11 10:21:15 -07:00
Tianon Gravi e21fe49dc9 Update "diff-pr" flags to be more aggressive about looking for similar files 2018-10-03 14:21:36 -07:00
Tianon Gravi dbfb3f3cd5 Add "--ignore-all-space" to "diff-pr.sh"
For the purposes of the review this script facilitates, whitespace is irrelevant.
2018-08-03 11:21:27 -07:00
Tianon Gravi f8555d46fd Update "diff-pr.sh" to strip leading "./" from tar entries 2018-04-20 09:58:15 -07:00
Tianon Gravi f1d5ef8b13 Let diff-pr be arch-aware 2018-03-20 10:59:32 -07:00
Tianon Gravi 6770ab304a Use "sort -u" in diff-pr to remove duplicates due to SharedTags 2017-11-01 12:19:08 -07:00
Tianon Gravi a92a4e8429 Add another "uninteresting directory" 2017-09-15 16:22:58 -07:00
Tianon Gravi b158337e0c Use the first arch of each entry in "diff-pr.sh"
This allows us to diff "windows-amd64"-only images, but doesn't solve the more general problem of how to cleanly show a diff across all architectures.
2017-07-13 10:35:50 -07:00
yosifkit dcfe2b8490 Merge pull request #3059 from infosiftr/diff-pr-shared-tags
Add "SharedTags" support to "diff-pr.sh"
2017-07-05 16:29:38 -07:00
Tianon Gravi f555445d48 Adjust template whitespace to match the rest of the file 2017-06-14 11:13:03 -07:00
Tianon Gravi 2ec4c7cc64 Fix "DockerFrom" failure on "windows-amd64"-only tags 2017-06-14 10:22:45 -07:00
Tianon Gravi cc73ad07d0 Add "SharedTags" support to "diff-pr.sh"
Example output of this bashbrew template (assuming `hello-world` had been converted to use `SharedTags`):

```console
$ bashbrew cat --format "$sharedTagsListTemplate" --all | grep -vE '^$'
hello-world:latest -- hello-world:linux, hello-world:nanoserver
```
2017-06-13 13:05:38 -07:00
Tianon Gravi 728e22d0d1 Add an "arches list" to "diff-pr" output
This should make it easier to see architecture changes (additions, removals, etc).
2017-06-08 15:34:50 -07:00
Tianon Gravi 764fc2406b Add some very basic initial support for BASHBREW_ARCH in "diff-pr.sh" 2017-06-06 09:33:19 -07:00
Tianon Gravi c0d1c0c69e Merge pull request #2558 from infosiftr/uninteresting-tarball-content
Remove certain paths from tarball output in "diff-pr"
2017-03-29 14:57:29 -07:00
Tianon Gravi 1ca9e62e9c Add "sort -V" to our "bashbrew list" for deterministic ordering (which should lead to simpler diffs overall) 2017-02-27 15:50:17 -08:00
Tianon Gravi 311e9d3637 Add "bashbrew list" output to "diff-pr.sh" 2017-02-24 12:48:25 -08:00
Tianon Gravi 9c8b8a0282 Remove certain paths from tarball output in "diff-pr"
These directories are simply noise in the diff (making it unnecessarily long, especially /var/lib/yum/yumdb)
2017-02-16 11:23:46 -08:00
Tianon Gravi 76e316ddca Remove "--depth 1" from "diff-pr.sh" to allow Git to detect overlap correctly 2016-09-26 12:53:02 -07:00
Joe Ferguson 9cf50096ac Allow globs in diff to get files beginning with `.` 2016-08-11 15:18:45 -07:00
Tianon Gravi c0bdcfa7f8 Add hacky "diff-pr.sh" script for generating diffs of PRs 2016-07-27 10:03:05 -07:00