dd3bb69a1e
clarify the appropriate place to use the debug flag when viewing warnings
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
(cherry picked from commit cedbc5d68d
2024-07-18 18:18:03 +02:00
fb773fa805
bake: check printer before printing warnings
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
(cherry picked from commit 7823a2dc01
2024-07-18 17:47:17 +02:00
153e5ed274
mark list-targets and list-variables as hidden and experimental
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-07-03 09:54:09 -07:00
cc097db675
bake: fix printer reset before metadata written
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-07-03 09:54:09 -07:00
233b869c63
bake: add list-variables option
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-07-03 09:54:03 -07:00
7460f049f2
bake: add list-targets options to list available targets/groups
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-07-03 09:54:03 -07:00
8f4c8b094a
bake: allow text descriptions for targets
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-07-03 09:54:03 -07:00
8da28574b0
bake: add call methods support and printing
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-07-03 09:54:02 -07:00
7b80ad7069
Merge pull request #2569 from dvdksn/fix-alias
...
fix: buildx b alias
2024-07-03 10:14:45 +02:00
048ef1fbf8
fix: buildx b alias
...
the shorthand "b" alias was accidentally removed in 19d838a
2024-07-03 10:03:01 +02:00
f374f64d2f
vendor: update buildkit to f7bda278b7e2
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-07-02 22:24:55 -07:00
19d838a3f4
docs: make buildx build the canonical doc
...
Move descriptions of flags common with the legacy build client to the buildx
build reference doc.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
2024-07-02 15:54:10 +02:00
17878d641e
Merge pull request #2534 from tonistiigi/bake-warnings
...
bake: print warnings on progress
2024-07-01 18:16:52 +02:00
59a0ffcf83
Merge pull request #2546 from treuherz/multinode-annotations
...
Pass in index annotations from builds on multiple nodes
2024-06-28 16:46:20 -07:00
2b17f277a1
Merge pull request #2549 from daghack/warning-free-msg
...
Add message when --check does not produce warnings or errors
2024-06-28 16:45:57 -07:00
f7a32361ea
use csvvalue package for parsing csv inputs
...
This package is better suited for parsing single-line
CSV strings.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-06-27 21:31:11 -07:00
c1f680df14
bake: print warnings on progress
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-06-27 17:31:15 -07:00
b6482ab6bb
Add message when --check does not produce warnings or errors
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
2024-06-27 08:24:00 -07:00
3971361ed2
Pass in index annotations from builds on multiple nodes
...
Fixes #2540
Signed-off-by: Eli Treuherz <et@arenko.group>
2024-06-27 13:26:07 +01:00
f7bcafed21
build: opt to set progress warnings in response
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-06-26 06:53:35 +02:00
d155747029
build: read provenance response mode in commands pkg
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-06-24 14:32:26 +02:00
366328ba6a
Add comment to document the purpose behind the non-standard handling of the error
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
2024-06-13 16:11:35 -07:00
927fb6731c
update the lint subrequest call to error when a build error was encountered during linting
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
2024-06-13 09:47:05 -07:00
1e3aec1ae2
docs: mention rawjson progress output mode
...
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
2024-06-06 16:51:42 +02:00
ef4a165e48
commands: add an alias for --check to be the same as --call=check
...
This adds an alias for `--check` that causes it to behave the same as
`--call=check`. This is done using `BoolFunc` to call a function when
the option is seen and to set it to the correct value. This should allow
command line flags like `--check --call=targets` to work correctly (even
though they conflict) by making it so the first invocation sets the
print function to `check` and the second overwrites the first. This is
the expected behavior for these types of boolean flags.
`BoolFunc` itself is part of the standard library flags package, but
never seems to have made it into pflag possibly because it was added in
go 1.21.
https://pkg.go.dev/flag#FlagSet.BoolFunc
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
2024-06-03 13:25:21 -05:00
89810dc998
build: set default call method name to build
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-06-03 10:42:35 -07:00
250cd44d70
Adds a --call flag as an alias to the --print flag and hides the later.
...
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
2024-06-03 10:30:30 -07:00
c58599ca50
dial-stdio: remove extra cmd.flags()
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-06-03 14:14:55 +02:00
abf6c77d91
Add a --prefer-index flag that allows you to specify the preferred behavior when deciding on how to create an image/manifest from a single source.
...
Signed-off-by: Tim Smith <tismith@rvohealth.com>
2024-05-29 14:07:28 -04:00
781dcbd196
prune: allow negative and prefix filters
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-05-24 16:57:25 -07:00
4fc4bc07ae
vendor: update buildx to latest docker/cli
...
This version of docker/cli has changes to remove compose-cli wrapper and
move all CLI metrics to OTEL.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
2024-05-16 12:07:13 -05:00
1fb5d2a9ee
Merge pull request #2422 from crazy-max/skip-provenance-internal
...
build: don't generate metadata file when print flag is used
2024-04-29 17:12:20 -07:00
ba264138d6
build: don't generate metadata file when print flag is used
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-04-26 10:53:46 +02:00
b30566438b
lint: gopls fixes
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-04-24 17:58:17 -07:00
46c44c58ae
build: support statuscode response for print requests
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-04-15 10:38:54 -07:00
46cf94092c
commands: use vendored formatter for lint responses
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-04-11 07:52:07 -07:00
2e2f9f571f
build: set record provenance in response
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-04-11 10:11:27 +02:00
ffff87be03
build: fix stdin handling when building with controller
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-04-09 14:49:30 +02:00
dc4b4c36bd
bake: load override
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-04-05 13:03:15 +02:00
5c29e6e26e
Merge pull request #2374 from tonistiigi/print-json-format
...
handle json formatting for print
2024-04-05 09:08:27 +02:00
b4799f9d16
metricutil: switch to using the cli meter provider
...
The meter provider initialization that was located here has now been
moved to a common area in the docker cli. This upgrades our CLI version
and then uses this common code instead of our own version.
As a piece of additional functionality, the docker OTEL endpoint can now
be overwritten with `DOCKER_CLI_OTEL_EXPORTER_OTLP_ENDPOINT` for
testing.
This removes the OTLP exporter from the CLI that was previously locked
behind `BUILDX_EXPERIMENTAL`. I do plan for this to return, but as a
proper part of the `docker/cli` implementation rather than something
special with `buildx`.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
2024-04-02 09:36:55 -05:00
858e347306
handle json formatting for print
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-04-01 16:46:04 -07:00
adb9bc86e5
vendor: github.com/docker/docker and github.com/docker/cli v26.0.0
...
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
2024-04-01 13:05:55 -05:00
2a30229916
chore: check experimental from confutil
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-03-15 11:52:41 +01:00
47cf4a5dbe
bake: fix output handling for push
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-03-12 13:13:13 +01:00
a03263acf8
build: handle push/load shorthands for multi exporters
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-03-05 17:05:59 +01:00
ce9a486a0e
commands: handle ctrl-c on active prompt
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2024-02-27 17:35:27 -08:00
af75d0bd7d
Merge pull request #2235 from jsternberg/build-context-transfer-metric
...
metrics: measure context transfers for local source operations
2024-02-23 13:25:58 -08:00
56fc68eb7e
driver: make buildkitd "config" and "flags" names consistent
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
2024-02-22 10:26:18 +01:00
97052cf203
metrics: measure context transfers for local source operations
...
Measure the transfer size and duration of context transfers for various
categories of local source transfers from the progress stream that's
returned during the build.
Local source transfers are split into one of four categories:
* context
* dockerfile
* dockerignore
* namedcontext
Named contexts that are different names will be categorized under the
same metric.
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
2024-02-21 14:52:03 -06:00
Talon Bowler
CrazyMax
Tonis Tiigi
David Karlsson
Eli Treuherz
CrazyMax
Jonathan A. Sternberg
Tim Smith