diff --git a/internal/registry/auth.go b/internal/registry/auth.go index e3ad9613d8..e15a139cb4 100644 --- a/internal/registry/auth.go +++ b/internal/registry/auth.go @@ -2,6 +2,7 @@ package registry import ( "context" + "fmt" "net/http" "net/url" "strings" @@ -12,7 +13,6 @@ import ( "github.com/docker/distribution/registry/client/auth/challenge" "github.com/docker/distribution/registry/client/transport" "github.com/moby/moby/api/types/registry" - "github.com/pkg/errors" ) // AuthClientID is used the ClientID used for the token server @@ -67,7 +67,7 @@ func loginV2(ctx context.Context, authConfig *registry.AuthConfig, endpoint APIE if resp.StatusCode != http.StatusOK { // TODO(dmcgowan): Attempt to further interpret result, status code and error code string - return "", errors.Errorf("login attempt to %s failed with status: %d %s", endpointStr, resp.StatusCode, http.StatusText(resp.StatusCode)) + return "", fmt.Errorf("login attempt to %s failed with status: %d %s", endpointStr, resp.StatusCode, http.StatusText(resp.StatusCode)) } return credentialAuthConfig.IdentityToken, nil diff --git a/internal/registry/config.go b/internal/registry/config.go index 72529f75df..b2f3070b1c 100644 --- a/internal/registry/config.go +++ b/internal/registry/config.go @@ -5,6 +5,7 @@ package registry import ( "context" + "fmt" "net" "net/url" "os" @@ -117,7 +118,7 @@ skip: r = host default: // unsupported scheme - return nil, invalidParamf("insecure registry %s should not contain '://'", r) + return nil, invalidParam(fmt.Errorf("insecure registry %s should not contain '://'", r)) } } // Check if CIDR was passed to --insecure-registry @@ -133,7 +134,7 @@ skip: insecureRegistryCIDRs = append(insecureRegistryCIDRs, ipnet) } else { if err := validateHostPort(r); err != nil { - return nil, invalidParamWrapf(err, "insecure registry %s is not valid", r) + return nil, invalidParam(fmt.Errorf("insecure registry %s is not valid: %w", r, err)) } // Assume `host:port` if not CIDR. indexConfigs[r] = ®istry.IndexInfo{ diff --git a/internal/registry/errors.go b/internal/registry/errors.go index 4174c91d15..9b321ab015 100644 --- a/internal/registry/errors.go +++ b/internal/registry/errors.go @@ -1,10 +1,11 @@ package registry import ( + "errors" + "fmt" "net/url" "github.com/docker/distribution/registry/api/errcode" - "github.com/pkg/errors" ) func translateV2AuthError(err error) error { @@ -23,11 +24,7 @@ func invalidParam(err error) error { } func invalidParamf(format string, args ...interface{}) error { - return invalidParameterErr{errors.Errorf(format, args...)} -} - -func invalidParamWrapf(err error, format string, args ...interface{}) error { - return invalidParameterErr{errors.Wrapf(err, format, args...)} + return invalidParameterErr{fmt.Errorf(format, args...)} } type unauthorizedErr struct{ error } diff --git a/internal/registry/registry.go b/internal/registry/registry.go index d69c1d9ec7..97946d7fd8 100644 --- a/internal/registry/registry.go +++ b/internal/registry/registry.go @@ -4,6 +4,7 @@ package registry import ( "context" "crypto/tls" + "fmt" "net" "net/http" "os" @@ -82,7 +83,7 @@ func loadTLSConfig(ctx context.Context, directory string, tlsConfig *tls.Config) if tlsConfig.RootCAs == nil { systemPool, err := tlsconfig.SystemCertPool() if err != nil { - return invalidParamWrapf(err, "unable to get system cert pool") + return invalidParam(fmt.Errorf("unable to get system cert pool: %w", err)) } tlsConfig.RootCAs = systemPool } diff --git a/internal/registry/service.go b/internal/registry/service.go index 51576387ae..0e29b98b04 100644 --- a/internal/registry/service.go +++ b/internal/registry/service.go @@ -4,6 +4,7 @@ import ( "context" "crypto/tls" "errors" + "fmt" "net/url" "strings" @@ -41,7 +42,7 @@ func (s *Service) Auth(ctx context.Context, authConfig *registry.AuthConfig, use } u, err := url.Parse(serverAddress) if err != nil { - return "", invalidParamWrapf(err, "unable to parse server address") + return "", invalidParam(fmt.Errorf("unable to parse server address: %w", err)) } registryHostName = u.Host }