fix typo filter param for `volumes`

https://docs.docker.com/engine/reference/api/docker_remote_api_v1.21/#list-volumes

Signed-off-by: Nicolas Delaby <nicolas.delaby@lock8.me>
This commit is contained in:
Nicolas Delaby 2015-12-01 15:06:01 +01:00
parent d51d06d209
commit 05fd8dfb41
2 changed files with 13 additions and 1 deletions

View File

@ -5,7 +5,7 @@ class VolumeApiMixin(object):
@utils.minimum_version('1.21') @utils.minimum_version('1.21')
def volumes(self, filters=None): def volumes(self, filters=None):
params = { params = {
'filter': utils.convert_filters(filters) if filters else None 'filters': utils.convert_filters(filters) if filters else None
} }
url = self._url('/volumes') url = self._url('/volumes')
return self._result(self._get(url, params=params), True) return self._result(self._get(url, params=params), True)

View File

@ -17,6 +17,18 @@ class VolumeTest(DockerClientTest):
self.assertEqual(args[0][0], 'GET') self.assertEqual(args[0][0], 'GET')
self.assertEqual(args[0][1], url_prefix + 'volumes') self.assertEqual(args[0][1], url_prefix + 'volumes')
@base.requires_api_version('1.21')
def test_list_volumes_and_filters(self):
volumes = self.client.volumes(filters={'dangling': True})
assert 'Volumes' in volumes
assert len(volumes['Volumes']) == 2
args = fake_request.call_args
assert args[0][0] == 'GET'
assert args[0][1] == url_prefix + 'volumes'
assert args[1] == {'params': {'filters': '{"dangling": ["true"]}'},
'timeout': 60}
@base.requires_api_version('1.21') @base.requires_api_version('1.21')
def test_create_volume(self): def test_create_volume(self):
name = 'perfectcherryblossom' name = 'perfectcherryblossom'