docker
/
docker-py
mirror of https://github.com/docker/docker-py.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix unit test which doesn't do anything 

It also overrode the fake API inspect endpoint with a broken
response.

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
This commit is contained in:
Ben Firshman 2016-09-07 10:47:06 +02:00
parent 08da5bfdfc
commit 0cdf737625
No known key found for this signature in database
GPG Key ID: 18296449E36D2F1E
2 changed files with 10 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/unit/container_test.py
View File

@ -751,14 +751,18 @@ class CreateContainerTest(DockerClientTest):
) )
def test_create_container_with_mac_address(self): def test_create_container_with_mac_address(self):
mac_address_expected = "02:42:ac:11:00:0a" expected = "02:42:ac:11:00:0a"
container = self.client.create_container( self.client.create_container(
'busybox', ['sleep', '60'], mac_address=mac_address_expected) 'busybox',
['sleep', '60'],
mac_address=expected
)
res = self.client.inspect_container(container['Id']) args = fake_request.call_args
self.assertEqual(mac_address_expected, self.assertEqual(args[0][1], url_prefix + 'containers/create')
res['NetworkSettings']['MacAddress']) data = json.loads(args[1]['data'])
assert data['MacAddress'] == expected
def test_create_container_with_links(self): def test_create_container_with_links(self):
link_path = 'path' link_path = 'path'

31
tests/unit/fake_api.py
View File

@ -169,35 +169,6 @@ def get_fake_inspect_image():
return status_code, response return status_code, response
def get_fake_port():
status_code = 200
response = {
'HostConfig': {
'Binds': None,
'ContainerIDFile': '',
'Links': None,
'LxcConf': None,
'PortBindings': {
'1111': None,
'1111/tcp': [{'HostIp': '127.0.0.1', 'HostPort': '4567'}],
'2222': None
},
'Privileged': False,
'PublishAllPorts': False
},
'NetworkSettings': {
'Bridge': 'docker0',
'PortMapping': None,
'Ports': {
'1111': None,
'1111/tcp': [{'HostIp': '127.0.0.1', 'HostPort': '4567'}],
'2222': None},
'MacAddress': '02:42:ac:11:00:0a'
}
}
return status_code, response
def get_fake_insert_image(): def get_fake_insert_image():
status_code = 200 status_code = 200
response = {'StatusCode': 0} response = {'StatusCode': 0}
@ -495,8 +466,6 @@ fake_responses = {
post_fake_pause_container, post_fake_pause_container,
'{1}/{0}/containers/3cc2351ab11b/unpause'.format(CURRENT_VERSION, prefix): '{1}/{0}/containers/3cc2351ab11b/unpause'.format(CURRENT_VERSION, prefix):
post_fake_unpause_container, post_fake_unpause_container,
'{1}/{0}/containers/3cc2351ab11b/json'.format(CURRENT_VERSION, prefix):
get_fake_port,
'{1}/{0}/containers/3cc2351ab11b/restart'.format(CURRENT_VERSION, prefix): '{1}/{0}/containers/3cc2351ab11b/restart'.format(CURRENT_VERSION, prefix):
post_fake_restart_container, post_fake_restart_container,
'{1}/{0}/containers/3cc2351ab11b'.format(CURRENT_VERSION, prefix): '{1}/{0}/containers/3cc2351ab11b'.format(CURRENT_VERSION, prefix):