Fix remove_volume return value

Signed-off-by: Sumit Sahrawat <sumit.sahrawat.apm13@iitbhu.ac.in>
This commit is contained in:
Sumit Sahrawat 2015-12-09 02:03:07 +05:30
parent bd948be7d9
commit 2981d013a5
4 changed files with 3 additions and 7 deletions

View File

@ -33,4 +33,3 @@ class VolumeApiMixin(object):
url = self._url('/volumes/{0}', name)
resp = self._delete(url)
self._raise_for_status(resp)
return True

View File

@ -780,8 +780,7 @@ Remove a volume. Similar to the `docker volume rm` command.
* name (str): The volume's name
**Returns** (bool): True on successful removal. Failure will raise a
`docker.errors.APIError` exception.
Failure to remove will raise a `docker.errors.APIError` exception.
## rename

View File

@ -47,8 +47,7 @@ class TestVolumes(helpers.BaseTestCase):
name = 'shootthebullet'
self.tmp_volumes.append(name)
self.client.create_volume(name)
result = self.client.remove_volume(name)
self.assertTrue(result)
self.client.remove_volume(name)
def test_remove_nonexistent_volume(self):
name = 'shootthebullet'

View File

@ -89,8 +89,7 @@ class VolumeTest(DockerClientTest):
@base.requires_api_version('1.21')
def test_remove_volume(self):
name = 'perfectcherryblossom'
result = self.client.remove_volume(name)
self.assertTrue(result)
self.client.remove_volume(name)
args = fake_request.call_args
self.assertEqual(args[0][0], 'DELETE')