mirror of https://github.com/docker/docker-py.git
Fix remove_volume return value
Signed-off-by: Sumit Sahrawat <sumit.sahrawat.apm13@iitbhu.ac.in>
This commit is contained in:
parent
bd948be7d9
commit
2981d013a5
|
@ -33,4 +33,3 @@ class VolumeApiMixin(object):
|
||||||
url = self._url('/volumes/{0}', name)
|
url = self._url('/volumes/{0}', name)
|
||||||
resp = self._delete(url)
|
resp = self._delete(url)
|
||||||
self._raise_for_status(resp)
|
self._raise_for_status(resp)
|
||||||
return True
|
|
||||||
|
|
|
@ -780,8 +780,7 @@ Remove a volume. Similar to the `docker volume rm` command.
|
||||||
|
|
||||||
* name (str): The volume's name
|
* name (str): The volume's name
|
||||||
|
|
||||||
**Returns** (bool): True on successful removal. Failure will raise a
|
Failure to remove will raise a `docker.errors.APIError` exception.
|
||||||
`docker.errors.APIError` exception.
|
|
||||||
|
|
||||||
## rename
|
## rename
|
||||||
|
|
||||||
|
|
|
@ -47,8 +47,7 @@ class TestVolumes(helpers.BaseTestCase):
|
||||||
name = 'shootthebullet'
|
name = 'shootthebullet'
|
||||||
self.tmp_volumes.append(name)
|
self.tmp_volumes.append(name)
|
||||||
self.client.create_volume(name)
|
self.client.create_volume(name)
|
||||||
result = self.client.remove_volume(name)
|
self.client.remove_volume(name)
|
||||||
self.assertTrue(result)
|
|
||||||
|
|
||||||
def test_remove_nonexistent_volume(self):
|
def test_remove_nonexistent_volume(self):
|
||||||
name = 'shootthebullet'
|
name = 'shootthebullet'
|
||||||
|
|
|
@ -89,8 +89,7 @@ class VolumeTest(DockerClientTest):
|
||||||
@base.requires_api_version('1.21')
|
@base.requires_api_version('1.21')
|
||||||
def test_remove_volume(self):
|
def test_remove_volume(self):
|
||||||
name = 'perfectcherryblossom'
|
name = 'perfectcherryblossom'
|
||||||
result = self.client.remove_volume(name)
|
self.client.remove_volume(name)
|
||||||
self.assertTrue(result)
|
|
||||||
args = fake_request.call_args
|
args = fake_request.call_args
|
||||||
|
|
||||||
self.assertEqual(args[0][0], 'DELETE')
|
self.assertEqual(args[0][0], 'DELETE')
|
||||||
|
|
Loading…
Reference in New Issue