diff --git a/docker/models/services.py b/docker/models/services.py index 4c8accef..337ed444 100644 --- a/docker/models/services.py +++ b/docker/models/services.py @@ -116,7 +116,7 @@ class Service(Model): ``True``if successful. """ - if not self.attrs['Spec']['Mode'].get('Global'): + if 'Global' in self.attrs['Spec']['Mode'].keys(): raise InvalidArgument('Cannot scale a global container') service_mode = ServiceMode('replicated', replicas) diff --git a/tests/integration/models_services_test.py b/tests/integration/models_services_test.py index 64aba66e..15b87da4 100644 --- a/tests/integration/models_services_test.py +++ b/tests/integration/models_services_test.py @@ -5,7 +5,7 @@ import docker from .. import helpers from .base import TEST_API_VERSION from docker.errors import InvalidArgument -from docker.models.services import ServiceMode +from docker.types.services import ServiceMode class ServiceTest(unittest.TestCase): @@ -212,7 +212,7 @@ class ServiceTest(unittest.TestCase): name=helpers.random_name(), # ContainerSpec arguments image="alpine", - command="sleep 300" + command="sleep 300", ) tasks = [] while len(tasks) == 0: