docker
/
docker-py
mirror of https://github.com/docker/docker-py.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1576 from robkooper/1572-replicas-0 

Fix if replicas is set to 0, Fixes #1572
This commit is contained in:
Joffrey F 2017-04-27 15:30:36 -07:00 committed by GitHub
parent f127a9ffdc 5f9a599b0f
commit 8ffa09b4b6
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docker/types/services.py
View File

@ -407,7 +407,7 @@ class ServiceMode(dict):
'replicas can only be used for replicated mode' 'replicas can only be used for replicated mode'
) )
self[mode] = {} self[mode] = {}
if replicas: if replicas is not None:
self[mode]['Replicas'] = replicas self[mode]['Replicas'] = replicas
@property @property

6
tests/unit/dockertypes_test.py
View File

@ -305,6 +305,12 @@ class ServiceModeTest(unittest.TestCase):
assert mode.mode == 'replicated' assert mode.mode == 'replicated'
assert mode.replicas == 21 assert mode.replicas == 21
def test_replicated_replicas_0(self):
mode = ServiceMode('replicated', 0)
assert mode == {'replicated': {'Replicas': 0}}
assert mode.mode == 'replicated'
assert mode.replicas == 0
def test_invalid_mode(self): def test_invalid_mode(self):
with pytest.raises(InvalidArgument): with pytest.raises(InvalidArgument):
ServiceMode('foobar') ServiceMode('foobar')