docker
/
docker-py
mirror of https://github.com/docker/docker-py.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update tests to properly dispose of client instances in tearDown 

Signed-off-by: Joffrey F <joffrey@docker.com>
This commit is contained in:
Joffrey F 2018-10-31 17:09:33 -07:00
parent 1df021ee24
commit 94aa9a89f7
4 changed files with 45 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/integration/api_network_test.py
View File

@ -8,8 +8,8 @@ from .base import BaseAPIIntegrationTest, BUSYBOX
class TestNetworks(BaseAPIIntegrationTest): class TestNetworks(BaseAPIIntegrationTest):
def tearDown(self): def tearDown(self):
super(TestNetworks, self).tearDown()
self.client.leave_swarm(force=True) self.client.leave_swarm(force=True)
super(TestNetworks, self).tearDown()
def create_network(self, *args, **kwargs): def create_network(self, *args, **kwargs):
net_name = random_name() net_name = random_name()

16
tests/integration/api_plugin_test.py
View File

@ -3,7 +3,7 @@ import os
import docker import docker
import pytest import pytest
from .base import BaseAPIIntegrationTest, TEST_API_VERSION from .base import BaseAPIIntegrationTest
from ..helpers import requires_api_version from ..helpers import requires_api_version
SSHFS = 'vieux/sshfs:latest' SSHFS = 'vieux/sshfs:latest'
@ -13,27 +13,27 @@ SSHFS = 'vieux/sshfs:latest'
class PluginTest(BaseAPIIntegrationTest): class PluginTest(BaseAPIIntegrationTest):
@classmethod @classmethod
def teardown_class(cls): def teardown_class(cls):
c = docker.APIClient( client = cls.get_client_instance()
version=TEST_API_VERSION, timeout=60,
**docker.utils.kwargs_from_env()
)
try: try:
c.remove_plugin(SSHFS, force=True) client.remove_plugin(SSHFS, force=True)
except docker.errors.APIError: except docker.errors.APIError:
pass pass
def teardown_method(self, method): def teardown_method(self, method):
client = self.get_client_instance()
try: try:
self.client.disable_plugin(SSHFS) client.disable_plugin(SSHFS)
except docker.errors.APIError: except docker.errors.APIError:
pass pass
for p in self.tmp_plugins: for p in self.tmp_plugins:
try: try:
self.client.remove_plugin(p, force=True) client.remove_plugin(p, force=True)
except docker.errors.APIError: except docker.errors.APIError:
pass pass
client.close()
def ensure_plugin_installed(self, plugin_name): def ensure_plugin_installed(self, plugin_name):
try: try:
return self.client.inspect_plugin(plugin_name) return self.client.inspect_plugin(plugin_name)

3
tests/integration/api_swarm_test.py
View File

@ -13,14 +13,13 @@ class SwarmTest(BaseAPIIntegrationTest):
self._unlock_key = None self._unlock_key = None
def tearDown(self): def tearDown(self):
super(SwarmTest, self).tearDown()
try: try:
if self._unlock_key: if self._unlock_key:
self.client.unlock_swarm(self._unlock_key) self.client.unlock_swarm(self._unlock_key)
except docker.errors.APIError: except docker.errors.APIError:
pass pass
force_leave_swarm(self.client) force_leave_swarm(self.client)
super(SwarmTest, self).tearDown()
@requires_api_version('1.24') @requires_api_version('1.24')
def test_init_swarm_simple(self): def test_init_swarm_simple(self):

3
tests/integration/base.py
View File

@ -29,6 +29,7 @@ class BaseIntegrationTest(unittest.TestCase):
def tearDown(self): def tearDown(self):
client = docker.from_env(version=TEST_API_VERSION) client = docker.from_env(version=TEST_API_VERSION)
try:
for img in self.tmp_imgs: for img in self.tmp_imgs:
try: try:
client.api.remove_image(img) client.api.remove_image(img)
@ -64,6 +65,8 @@ class BaseIntegrationTest(unittest.TestCase):
for folder in self.tmp_folders: for folder in self.tmp_folders:
shutil.rmtree(folder) shutil.rmtree(folder)
finally:
client.close()
class BaseAPIIntegrationTest(BaseIntegrationTest): class BaseAPIIntegrationTest(BaseIntegrationTest):