docker
/
docker-py
mirror of https://github.com/docker/docker-py.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1653 from osallou/master 

Closes #1588, image.tag does not return anything
This commit is contained in:
Joffrey F 2017-06-16 11:32:25 -07:00 committed by GitHub
parent 8fc6540fea d638829f73
commit a9d4c7e2b6
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docker/models/images.py
View File

@ -96,7 +96,7 @@ class Image(Model):
Returns: Returns:
(bool): ``True`` if successful (bool): ``True`` if successful
""" """
self.client.api.tag(self.id, repository, tag=tag, **kwargs) return self.client.api.tag(self.id, repository, tag=tag, **kwargs)
class ImageCollection(Collection): class ImageCollection(Collection):

3
tests/integration/models_images_test.py
View File

@ -71,7 +71,8 @@ class ImageTest(BaseIntegrationTest):
client = docker.from_env(version=TEST_API_VERSION) client = docker.from_env(version=TEST_API_VERSION)
image = client.images.pull('alpine:latest') image = client.images.pull('alpine:latest')
image.tag(repo, tag) result = image.tag(repo, tag)
assert result is True
self.tmp_imgs.append(identifier) self.tmp_imgs.append(identifier)
assert image.id in get_ids(client.images.list(repo)) assert image.id in get_ids(client.images.list(repo))
assert image.id in get_ids(client.images.list(identifier)) assert image.id in get_ids(client.images.list(identifier))