docker
/
docker-py
mirror of https://github.com/docker/docker-py.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

integration: Fix bad subnet declaration 

Some network integration tests are creating networks with subnet
`2001:389::1/64`. This is an invalid subnet as the host fragment is
non-zero (ie. it should be `2001:389::/64`).

PR moby/moby#45759 is adding strict validation of network configuration.
Docker API will now return an error whenever a bad subnet is passed.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
This commit is contained in:
Albin Kerouanton 2023-08-07 11:11:39 +02:00
parent 0f0b20a6a7
commit aa793a0827
No known key found for this signature in database
GPG Key ID: 630B8E1DCBDB1864
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/integration/api_network_test.py
View File

@ -233,7 +233,7 @@ class TestNetworks(BaseAPIIntegrationTest):
net_name, net_id = self.create_network( net_name, net_id = self.create_network(
ipam=IPAMConfig( ipam=IPAMConfig(
driver='default', driver='default',
pool_configs=[IPAMPool(subnet="2001:389::1/64")], pool_configs=[IPAMPool(subnet="2001:389::/64")],
), ),
) )
container = self.client.create_container( container = self.client.create_container(
@ -389,7 +389,7 @@ class TestNetworks(BaseAPIIntegrationTest):
driver='default', driver='default',
pool_configs=[ pool_configs=[
IPAMPool( IPAMPool(
subnet="2001:389::1/64", iprange="2001:389::0/96", subnet="2001:389::/64", iprange="2001:389::0/96",
gateway="2001:389::ffff" gateway="2001:389::ffff"
) )
] ]
@ -455,7 +455,7 @@ class TestNetworks(BaseAPIIntegrationTest):
driver='default', driver='default',
pool_configs=[ pool_configs=[
IPAMPool( IPAMPool(
subnet="2001:389::1/64", iprange="2001:389::0/96", subnet="2001:389::/64", iprange="2001:389::0/96",
gateway="2001:389::ffff" gateway="2001:389::ffff"
) )
] ]