From 9f3f97ce944965dc041bdc49d06c771757288388 Mon Sep 17 00:00:00 2001 From: ben avrahami Date: Mon, 26 Jul 2021 14:05:13 +0300 Subject: [PATCH] Fixed value for missing host port for newer docker desktop versions Signed-off-by: Ben Avrahami --- docker/utils/utils.py | 2 +- tests/unit/api_container_test.py | 2 +- tests/unit/models_containers_test.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docker/utils/utils.py b/docker/utils/utils.py index f7c3dd7d..f2f5c28e 100644 --- a/docker/utils/utils.py +++ b/docker/utils/utils.py @@ -88,7 +88,7 @@ def _convert_port_binding(binding): result['HostPort'] = binding if result['HostPort'] is None: - result['HostPort'] = '' + result['HostPort'] = '0' else: result['HostPort'] = str(result['HostPort']) diff --git a/tests/unit/api_container_test.py b/tests/unit/api_container_test.py index 1ebd37df..ebfdcaf4 100644 --- a/tests/unit/api_container_test.py +++ b/tests/unit/api_container_test.py @@ -577,7 +577,7 @@ class CreateContainerTest(BaseAPIClientTest): assert '4444/tcp' in port_bindings assert '5555/tcp' in port_bindings assert '6666/tcp' in port_bindings - assert [{"HostPort": "", "HostIp": ""}] == port_bindings['1111/tcp'] + assert [{"HostPort": "0", "HostIp": ""}] == port_bindings['1111/tcp'] assert [ {"HostPort": "2222", "HostIp": ""} ] == port_bindings['2222/tcp'] diff --git a/tests/unit/models_containers_test.py b/tests/unit/models_containers_test.py index c7aa46b2..d2334ec9 100644 --- a/tests/unit/models_containers_test.py +++ b/tests/unit/models_containers_test.py @@ -163,7 +163,7 @@ class ContainerCollectionTest(unittest.TestCase): 'PidsLimit': 500, 'PortBindings': { '1111/tcp': [{'HostIp': '', 'HostPort': '4567'}], - '2222/tcp': [{'HostIp': '', 'HostPort': ''}] + '2222/tcp': [{'HostIp': '', 'HostPort': '0'}] }, 'Privileged': True, 'PublishAllPorts': True,