docker
/
docker-py
mirror of https://github.com/docker/docker-py.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

convert_service_ports takes only a dict as param 

Signed-off-by: billou <nabil.benyoussef@gmail.com>
This commit is contained in:
billou 2024-07-12 22:05:55 -04:00
parent a3652028b1
commit bc5bcdade5
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docker/types/services.py
View File

@ -560,11 +560,9 @@ class EndpointSpec(dict):
def convert_service_ports(ports): def convert_service_ports(ports):
if isinstance(ports, list):
return ports
if not isinstance(ports, dict): if not isinstance(ports, dict):
raise TypeError( raise TypeError(
'Invalid type for ports, expected dict or list' 'Invalid type for ports, expected dict'
) )
result = [] result = []

6
tests/unit/dockertypes_test.py
View File

@ -491,3 +491,9 @@ class ServicePortsTest(unittest.TestCase):
} in converted_ports } in converted_ports
assert len(converted_ports) == 3 assert len(converted_ports) == 3
def test_convert_service_ports_wrong_ports_type(self):
ports = 'ports_as_string'
with pytest.raises(TypeError):
convert_service_ports(ports)