From d5c4ce203aa5839966a221079d1be44e572e92af Mon Sep 17 00:00:00 2001 From: Joffrey F Date: Tue, 15 Aug 2017 17:40:07 -0700 Subject: [PATCH] Use better version comparison function Signed-off-by: Joffrey F --- docker/models/containers.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docker/models/containers.py b/docker/models/containers.py index d9db79df..688decca 100644 --- a/docker/models/containers.py +++ b/docker/models/containers.py @@ -4,7 +4,7 @@ from ..api import APIClient from ..errors import (ContainerError, ImageNotFound, create_unexpected_kwargs_error) from ..types import HostConfig -from ..utils import compare_version +from ..utils import version_gte from .images import Image from .resource import Collection, Model @@ -691,8 +691,7 @@ class ContainerCollection(Collection): image = image.id detach = kwargs.pop("detach", False) if detach and remove: - if compare_version("1.24", - self.client.api._version) > 0: + if version_gte(self.client.api._version, '1.25'): kwargs["auto_remove"] = True else: raise RuntimeError("The options 'detach' and 'remove' cannot "