Ulysses Souza
b05bfd7b22
Fix base_url to keep TCP protocol
...
This fix lets the responsability of changing the
protocol to `parse_host` afterwards, letting
`base_url` with the original value.
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
2019-03-28 14:16:52 +01:00
Ulysses Souza
33b8fd6eec
Xfail test_attach_stream_and_cancel on TLS
...
This test is quite flaky on ssl integration test
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
2019-03-28 14:16:18 +01:00
Joffrey F
a579e9e205
Remove use_config_proxy from exec. Add use_config_proxy docs to DockerClient
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2019-01-09 14:45:13 -08:00
Sebastiaan van Stijn
219c52141e
Regression 443 test: relax status-code check
...
This test was testing for a 500 status, but this status
is actually a bug in the API (as it's due to an invalid
request), and the API should actually return a 400 status.
To make this test handle both situations, relax the test
to accept either a 4xx or 5xx status.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-01-09 21:23:11 +01:00
Joffrey F
65bebc085a
Style fixes and removed some unused code
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2019-01-09 11:30:58 -08:00
Corentin Henry
2c4a8651a8
By default, disable proxy support
...
This is to avoid a breaking change
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2019-01-09 11:30:58 -08:00
Corentin Henry
0d37390c46
add integration tests for proxy support
...
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2019-01-09 11:30:58 -08:00
Corentin Henry
545adc2a59
add unit tests for ProxyConfig
...
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2019-01-09 11:30:58 -08:00
Corentin Henry
6e227895d3
tests: remove outdated code
...
the _cfg attribute does not exist anymore
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2019-01-09 11:30:58 -08:00
Joffrey F
72f4f527ad
Update test dependencies to latest version, fix some flake8 errors
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2019-01-09 11:18:40 -08:00
Joffrey F
c344660f20
Merge pull request #2188 from docker/c6374-credhelpers
...
Modernize auth management
2018-11-30 15:32:30 -08:00
Joffrey F
b2ad302636
Fix test names
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-30 14:58:18 -08:00
Joffrey F
ee6ec4c6e8
Merge branch 'master' of https://github.com/little-dude/docker-py into little-dude-master
2018-11-30 14:48:19 -08:00
Joffrey F
cc38efa68e
Add some credHelpers tests
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-30 14:41:56 -08:00
Joffrey F
01ccaa6af2
Make AuthConfig a dict subclass for backward-compatibility
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-30 13:51:01 -08:00
Joffrey F
bc5d7c8cb6
Modernize auth management
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-28 19:32:01 -08:00
Corentin Henry
7b3b83dfdb
fix exec api inconsistency
...
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2018-11-28 15:16:23 -08:00
Corentin Henry
76447d0ca3
tests various exec_create/exec_start combinations
...
Test the interation of the tty, demux and stream parameters
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2018-11-28 13:37:17 -08:00
Corentin Henry
6540900dae
add tests for _read_from_socket
...
Check that the return value against the various combination of
parameters this function can take (tty, stream, and demux).
This commit also fixes a bug that the tests uncovered a bug in
consume_socket_output.
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2018-11-28 13:37:10 -08:00
Joffrey F
c53423f118
Update DockerClient.images.pull to always stream response
...
Also raise a warning when users attempt to specify the "stream" parameter
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-28 11:27:04 -08:00
adw1n
a74d546864
Fix pulling images with `stream=True`
...
Pulling an image with option `stream=True` like this:
```
client.api.pull('docker.io/user/repo_name', tag='latest', stream=True)
```
without consuming the generator oftentimes results in premature drop of the connection. Docker daemon tries to send progress of pulling the image to the client, but it encounters an error (broken pipe) and therefore cancells the pull action:
```
Thread 1 "dockerd-dev" received signal SIGPIPE, Broken pipe.
ERRO[2018-09-03T05:12:35.746497638+02:00] Not continuing with pull after error: context canceled
```
As described in issue #2116 , even though client receives response with status code 200, image is not pulled.
Closes #2116
Signed-off-by: Przemysław Adamek <adw1n@users.noreply.github.com>
2018-11-28 11:27:04 -08:00
Corentin Henry
5f157bbaca
implement stream demultiplexing for exec commands
...
fixes https://github.com/docker/docker-py/issues/1952
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2018-11-27 17:01:48 -08:00
Joffrey F
114630161a
Correctly handle longpath prefix in process_dockerfile when joining paths
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-26 17:34:26 -08:00
Corentin Henry
47c10aa383
tests: fix failure due to pytest deprecation
...
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
2018-11-21 17:17:50 -08:00
Joffrey F
f83fe7c959
Properly convert non-string filters to expected string format
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-08 17:22:24 -08:00
Joffrey F
e237c0ea16
Add named parameter to image.save to identify which repository name to use in the resulting tarball
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-06 14:46:37 -08:00
Joffrey F
f302756599
Rewrite utils.parse_host to detect more invalid addresses.
...
The method now uses parsing methods from urllib to better split provided URLs.
Addresses containing query strings, parameters, passwords or fragments no longer fail silently.
SSH addresses containing paths are no longer accepted.
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-01 15:44:43 -07:00
Joffrey F
6bfe2005e0
Clear error for cancellable streams over SSH
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-01 15:24:22 -07:00
Joffrey F
94aa9a89f7
Update tests to properly dispose of client instances in tearDown
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-01 15:24:22 -07:00
Joffrey F
1df021ee24
Update tests for ssh protocol compatibility
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-01 15:24:22 -07:00
Joffrey F
a3111d9e00
Add xfail to ignore 18.09 beta bug
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-10-31 18:05:26 -07:00
Joffrey F
82445764e0
Add support for RollbackConfig
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-08-09 16:41:25 -07:00
Joffrey F
14524f19e2
Add version checks and test
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-08-09 15:56:11 -07:00
Joffrey F
cc766633de
Merge pull request #2103 from asottile/allow_uid_integer_0
...
Allow user=0 to be passed in create_container
2018-08-06 14:21:32 -07:00
Joffrey F
c28ff85542
Improve placement handling in DockerClient.services.create
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-08-03 14:04:04 -07:00
Anthony Sottile
3c9738a584
Allow user=0 to be passed in create_container
...
Signed-off-by: Anthony Sottile <asottile@umich.edu>
2018-08-02 12:00:55 -07:00
Joffrey F
b3d2e54a2d
Merge pull request #2063 from mtszb/master
...
Add support for `uts_mode` parameter in `Client.create_host_config`.
2018-06-29 11:20:51 -07:00
Marco Trillo
098318ad95
Add support for `uts_mode` parameter in `Client.create_host_config`.
...
This parameter allows to set the UTS namespace of the container, as in
the `--uts=X` Docker CLI parameter:
<https://docs.docker.com/engine/reference/run/#uts-settings---uts >
The only allowed value, if set, is "host".
Signed-off-by: Marco Trillo <martri@arantia.com>
Signed-off-by: Diego Alvarez <dyako.developer@gmail.com>
2018-06-29 14:54:49 +02:00
Joffrey F
ced86ec813
On Windows, convert paths to use forward slashes before fnmatch call
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-06-28 17:11:24 -07:00
Joffrey F
81b7d48ad6
Improved .dockerignore pattern processing to better match Docker CLI behavior
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-06-28 17:11:24 -07:00
Joffrey F
e195e022cf
Fix detach assert function to account for new behavior in engine 18.06
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-06-28 16:33:06 -07:00
Joffrey F
8c35eee0fb
Fix support for legacy .dockercfg auth config format
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-06-27 17:04:32 -07:00
Joffrey F
f1189bfb4b
Allow passing of env overrides to credstore through APIClient ctor
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-06-08 15:43:58 -07:00
Joffrey F
dbe52dcb7d
Fix socket reading function for TCP (non-HTTPS) connections on Windows
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-06-06 17:53:50 -07:00
Joffrey F
b4efdc1b28
Fix several integration tests on Windows
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-05-25 10:11:02 -07:00
Joffrey F
95ad903c35
Fix create_plugin on Windows
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-05-25 10:11:02 -07:00
Joffrey F
17f41b5672
Avoid unwanted modification of dockerfile path
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-05-25 10:11:02 -07:00
Joffrey F
9709dd454b
Add ignore_removed param to containers.list() to control whether to
...
raise or ignore NotFound
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-04-25 17:18:26 -07:00
Joffrey F
827bd98d07
Merge branch 'master' of github.com:docker/docker-py
2018-04-25 16:30:24 -07:00
Joffrey F
8360ecae97
prune_builds test
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-04-25 16:29:41 -07:00