Commit Graph

3158 Commits

Author SHA1 Message Date
aiordache 260114229a Update Jenkinsfile with docker registry credentials
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-11-19 18:51:59 +01:00
Anca Iordache 5b471d4482
Merge pull request #2704 from aiordache/cleanup
Fix condition to avoid syntax warning
2020-11-19 18:18:09 +01:00
aiordache a0c51be228 Syntax warning fix
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-11-19 15:38:26 +01:00
Anca Iordache 27e3fa3e2e
Merge pull request #2703 from aiordache/cleanup_before_release
Fix docs typo and `port_bindings` check
2020-11-19 09:53:39 +01:00
aiordache db9af44e5b Fix docs typo
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-11-18 19:00:27 +01:00
Anca Iordache d83a2ad51b
Merge pull request #2691 from aiordache/fix_ssh_conn
Fix the connection via ssh client shellout
2020-11-18 15:55:25 +01:00
aiordache f5531a94e1 Fix ssh connection - don't override the host and port of the http pool
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-11-18 14:44:24 +01:00
Guillaume Tardif 6da140e26c
Merge pull request #2511 from daeseokyoun/handle-network-host
raise an error for binding specific ports in 'host' mode of network
2020-11-17 16:01:16 +01:00
Mariano Scazzariello bb1c528ab3
Add max_pool_size parameter (#2699)
* Add max_pool_size parameter

Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>

* Add client version to tests

Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>

* Fix parameter position

Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>
2020-11-17 15:42:36 +01:00
Daeseok Youn 433264d04b Correct comments on ports_binding and host mode as network_mode
Signed-off-by: Daeseok Youn <daeseok.youn@navercorp.com>
2020-11-17 21:27:15 +09:00
Daeseok Youn 9c53024ead raise an error for binding specific ports in 'host' mode of network
The binding ports are ignored where the network mode is 'host'.
It could be a problem in case of using these options together on
Mac or Windows OS. Because the limitation that could not use
the 'host' in network_mode on Mac and Windows. When 'host' mode
is set on network_mode, the specific ports in 'ports' are ignored
 so the network is not able to be accessed through defined ports
by developer.

Signed-off-by: Daeseok Youn <daeseok.youn@navercorp.com>
2020-11-17 21:26:55 +09:00
Anca Iordache 800222268a
Merge pull request #2553 from fengbaolong/fix-unicode-in-dockerfile
fix docker build error when dockerfile contains unicode character.
2020-11-16 17:44:09 +01:00
Anca Iordache 8c893dd9c4
Merge pull request #2694 from docker/dependabot/pip/cryptography-3.2
Bump cryptography from 2.3 to 3.2
2020-11-16 16:48:19 +01:00
Anca Iordache 5b60bba104
Merge pull request #2642 from YuviGold/feature/api-server-error-message-url
Add response url to Server Error and Client Error messages
2020-11-16 15:50:04 +01:00
dependabot[bot] 93bcc0497d
Bump cryptography from 2.3 to 3.2
Bumps [cryptography](https://github.com/pyca/cryptography) from 2.3 to 3.2.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/2.3...3.2)

Signed-off-by: dependabot[bot] <support@github.com>
2020-10-27 21:18:15 +00:00
Yuval Goldberg 3766f77c20 Add response url to Server Error and Client Error messages
Signed-off-by: Yuval Goldberg <yuvigoldi@hotmail.com>
2020-10-17 03:43:11 +03:00
Anca Iordache 2c6ef9b11d
Merge pull request #2687 from IamTheFij/fix-model-plugin-upgrade-reload
Fix plugin model upgrade
2020-10-16 11:37:36 +02:00
Anca Iordache daa9f179c3
Merge pull request #2671 from aiordache/default_tag
Set image default tag on pull
2020-10-16 11:35:16 +02:00
Anca Iordache e09b070575
Merge pull request #2680 from aiordache/replace_paramiko
Shell out to local SSH client as alternative to a paramiko connection
2020-10-16 11:34:00 +02:00
aiordache 180414dcbb Shell out to SSH client for an ssh connection
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-13 10:42:38 +02:00
Ian Fijolek 910cc12423 Fix plugin model upgrade
When upgrading a plugin via the model interface, it would yield the
following error:

    AttributeError: 'Plugin' object has no attribute '_reload'

It appears that the proper method is `self.reload()`. This is what is
used by all other methods in the class and base. I'm not finding any
references to `_reload` apart from this instance in the project either.

I've verified that this patch fixes the issue on my machine and all
tests pass.

Signed-off-by: Ian Fijolek <ian@iamthefij.com>
2020-10-09 18:29:26 -07:00
Anca Iordache 9d8cd023e8
Merge pull request #2673 from ulyssessouza/remove-tinyurl-link
Fix url of examples in ulimits
2020-09-28 11:14:27 +02:00
aiordache aed5700985 update `pull` method docs
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-21 10:23:29 +02:00
Ulysses Souza ea093a75dd Fix url of examples in ulimits
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-09-17 17:09:14 +02:00
Anca Iordache ff44e7e375
Merge pull request #2670 from ulyssessouza/add-github-maintainers
Add github supported CODEOWNERS file
2020-09-17 16:54:30 +02:00
aiordache cec152db5f Set image default tag on pull
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-16 17:36:50 +02:00
Ulysses Souza 84857a896c Add github supported CODEOWNERS file
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-09-15 15:33:04 +02:00
aiordache ed46fb0143 Add release 4.3.1 information to changelog
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-07 17:55:36 +02:00
Anca Iordache 2b1c7eb724
Merge pull request #2650 from aiordache/default_version_auto
Set default version to 'auto'
2020-08-20 20:58:25 +02:00
Anca Iordache f158888003
Merge pull request #2534 from HaaLeo/feature/openssh-identity-file
Support OpenSSH Identityfile option
2020-08-20 18:33:45 +02:00
aiordache c7c5b551fc set engine version for unit tests to avoid querying the engine
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-20 15:29:24 +02:00
aiordache 727080b3cc set version to 'auto' to avoid breaking on old engine versions
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-19 14:19:29 +02:00
Yuval Goldberg 0dfae33ce8 Add file environment variable to integration-dind
Signed-off-by: Yuval Goldberg <yuvigoldi@hotmail.com>
2020-08-18 15:18:52 +02:00
Anca Iordache 2c522fb362
Fix memory conversion to bytes (#2645)
* Fix memory conversion to bytes

Co-authored-by: Ulysses Souza <ulysses.souza@gmail.com>

Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-17 18:32:48 +02:00
Anca Iordache 30ff9f339c
Merge pull request #2638 from aiordache/release
Release 4.3.0
2020-08-10 19:35:01 +02:00
aiordache 5cdbbab3ee Update version to the next dev version
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-10 19:21:44 +02:00
aiordache 9579b7ac0e Fix changelog merge
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-10 19:16:52 +02:00
aiordache 8080fbb4ed Fix merge
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-10 19:15:50 +02:00
aiordache 746a2509ab Prepare release 4.3.0
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-10 19:15:50 +02:00
aiordache 3999707fb3 Make orchestrator field optional
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-10 19:15:50 +02:00
Ulysses Souza 2e274d00b3 Specify when to use `tls` on Context constructor
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-08-10 19:15:50 +02:00
Ulysses Souza 67b77f2fa3 Post release 4.2.0 update:
- Changelog
- Next Version

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-08-10 19:15:46 +02:00
Anca Iordache 087b3f0a49 Implement context management, lifecycle and unittests.
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
2020-08-10 19:14:00 +02:00
Till Riedel fcd0093050 obey Hostname Username Port and ProxyCommand settings from .ssh/config
Signed-off-by: Till Riedel <riedel@teco.edu>
2020-08-10 19:14:00 +02:00
Till Riedel 70cdb08f9a set logging level of paramiko to warn
Signed-off-by: Till Riedel <riedel@teco.edu>
2020-08-10 19:14:00 +02:00
Sebastiaan van Stijn 0be75d54ca Update credentials-helpers to v0.6.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-08-10 19:14:00 +02:00
Sebastiaan van Stijn b4beaaac8c
Update default API version to v1.39 (#2512)
* Update default API version to v1.39

When running the docker-py integration tests in the Moby repository, some
tests were skipped because the API version used was too low:

    SKIPPED [1] tests/integration/api_service_test.py:882: API version is too low (< 1.38)
    SKIPPED [1] tests/integration/api_swarm_test.py:59: API version is too low (< 1.39)
    SKIPPED [1] tests/integration/api_swarm_test.py:38: API version is too low (< 1.39)
    SKIPPED [1] tests/integration/api_swarm_test.py:45: API version is too low (< 1.39)
    SKIPPED [1] tests/integration/api_swarm_test.py:52: API version is too low (< 1.39)

While it's possible to override the API version to use for testing
using the `DOCKER_TEST_API_VERSION` environment variable, we may want
to set the default to a version that supports all features that were
added.

This patch updates the default API version to v1.39, which is the minimum
version required for those features, and corresponds with Docker 18.09.

Note that the API version of the current (19.03) Docker release is v1.40,
but using that version as default would exclude users that did not update
their Docker version yet (and would not be needed yet for the features provided).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Makefile: set DOCKER_TEST_API_VERSION to v1.39

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-08-07 16:45:20 +02:00
Anca Iordache cceae0c384
Merge pull request #2572 from scop/tlsconfig-error-messages
Fix parameter names in TLSConfig error messages
2020-08-07 15:14:39 +02:00
Anca Iordache 6367bbee2e
Merge pull request #2520 from Nicceboy/master
Disable compression by default when using container:get_archive method
2020-08-07 14:42:58 +02:00
Anca Iordache 62afadc13b
Merge pull request #2584 from thaJeztah/bump_engine
Update test engine version to 19.03.12
2020-08-07 14:34:06 +02:00