The command line and daemon started supporting --device
parameter during docker start a while ago in the following commit:
docker/docker@e855c4b
Since the command line looks like this,
--device=[] Add a host device to the container (e.g. --device=/dev/sdc:/dev/xvdc)
This patch allows a list of strings to be passed into the start() method
and we parse out the 3 components just like in the above mentioned commit
This change adds both files and directories to the tra-file for the
Docker context. Previously only files where added.
The context will now also contain empty directoryes and symlinks
to directories.
It assumes you've got Docker running on /var/run/docker.sock, but
that should be the case on both Linux and in Boot2Docker.
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
When calling attach_socket, the response is garbage collected,
which triggers a close method on the file object, closing the socket.
This stop the response from being garbage collected until we've
finished with the underlying socket.
Fixes#350
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
- Check that `urllib_ver` is not None, instead of `urllib3`
- Do version comparison only if `urllib_ver` is *not* "dev"
Fixes#325. Original work by @sidprak.
[`filters` is a json encoded value of the filters (a map[string][string]) to process on the images list. ][1]
The tricky thing is that we must convert boolean value to string and any filter value to list to make a `map[string][string]` json format
[1]: https://docs.docker.com/reference/api/docker_remote_api_v1.14/#list-images
The server responds with an unuseful message (server error EOF), which
happens because an empty tar file is sent over. So check in the client,
who knows why that's happening and tell the user.