Filipe Utzig
467116817a
Merge acc26364cc into 6e6a273573
2025-06-17 22:18:15 -03:00
Sebastiaan van Stijn
e47e966e94
Bump default API version to 1.45 (Moby 26.0/26.1)
...
- Update API version to the latest maintained release.
0 Adjust tests for API 1.45
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-27 17:03:02 +01:00
Laura Brehm
b1265470e6
tests/exec: add test for exit code from exec
...
Execs should return the exit code of the exec'd process, if it started.
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
2024-09-30 14:07:04 +01:00
Laura Brehm
96ef4d3bee
tests/exec: expect 127 exit code for missing executable
...
Docker Engine has always returned `126` when starting an exec fails due
to a missing binary, but this was due to a bug in the daemon causing the
correct exit code to be overwritten in some cases – see: https://github.com/moby/moby/issues/45795
Change tests to expect correct exit code (`127`).
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
2024-09-27 15:33:11 +01:00
Filipe Utzig
acc26364cc
Remove and return container when start fails
...
When the container fail to start and the user has set the `remove` flag
we should remove the containter, also if the flag is not set, we lose
track of the container, leaving it dangling on the system. By adding
this execption return whenever the container fails to start we provide
means to the user to remove the container if needed.
Signed-off-by: Filipe Utzig <filipe@gringolito.com>
2024-09-12 17:12:59 -03:00
Milas Bowman
4c6437d292
Merge pull request #3212 from valohai/ruff-i
2024-03-29 13:28:43 -04:00
Rob Murray
cb21af7f69
Fix tests that look at 'Aliases'
...
Inspect output for 'NetworkSettings.Networks.<network>.Aliases'
includes the container's short-id (although it will be removed
in API v1.45, in moby 26.0).
Signed-off-by: Rob Murray <rob.murray@docker.com>
2024-03-13 14:54:25 +00:00
Aarni Koskela
d50cc429c2
Enable Ruff I (import sort), autofix
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2024-01-03 21:28:56 +02:00
Milas Bowman
26e07251d4
chore: fix lint issues
...
ruff ruff ruff!
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-11-20 16:11:06 -05:00
Milas Bowman
b70cbd0129
Merge remote-tracking branch 'upstream/main' into Skazza94/main
2023-11-20 15:38:27 -05:00
Mariano Scazzariello
7752996f78
Replace `network_config` with a dict of EndpointConfig
...
- Renamed parameter from `network_config` to `networking_config` to be more semantically correct with the rest of the API.
2023-09-30 00:20:44 +02:00
Aarni Koskela
0566f1260c
Fix missing asserts or assignments
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2023-08-15 13:36:53 +03:00
Aarni Koskela
601476733c
Enable Ruff C rules and autofix
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2023-08-15 13:36:53 +03:00
Aarni Koskela
8a3402c049
Replace string formatting with f-strings
...
Signed-off-by: Aarni Koskela <akx@iki.fi>
2023-08-15 13:36:53 +03:00
Mariano Scazzariello
e011ff5be8
More sanity checking of EndpointConfig params
...
Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>
2023-05-07 12:40:08 +02:00
Joffrey F
87ee18aa39
Change use_config_proxy default value to True to match CLI behavior
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2019-05-01 20:52:01 -07:00
Ulysses Souza
d1f7979f24
Refactor and add tests
...
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
2019-03-26 17:28:49 +01:00
Karl Kuehn
4890864d65
add ports to containers
...
Signed-off-by: Karl Kuehn <kuehn.karl@gmail.com>
2019-03-26 16:55:45 +01:00
Ian Campbell
c1fea8ee4a
Merge pull request #2288 from hannseman/container-run-create-volume_driver
...
Move volume_driver to RUN_HOST_CONFIG_KWARGS
2019-03-25 12:24:54 +00:00
Ulysses Souza
8f42dd1484
Avoid race condition on short execution
...
- Add a sleep of 2 seconds to be sure the logs
can be requested before the daemon removes the
container when run with auto_remove=True
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
2019-03-25 12:42:54 +01:00
Hannes Ljungberg
523371e21d
Move volume_driver to RUN_HOST_CONFIG_KWARGS
...
Fixes #2271
Signed-off-by: Hannes Ljungberg <hannes@5monkeys.se>
2019-03-23 20:57:23 +01:00
Joffrey F
a579e9e205
Remove use_config_proxy from exec. Add use_config_proxy docs to DockerClient
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2019-01-09 14:45:13 -08:00
Joffrey F
6bfe2005e0
Clear error for cancellable streams over SSH
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-11-01 15:24:22 -07:00
Joffrey F
b4efdc1b28
Fix several integration tests on Windows
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-05-25 10:11:02 -07:00
Joffrey F
284c3d90d6
Remove redundant single-socket select call
...
Clean up + use pytest-timeout
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-03-20 09:25:29 +01:00
Viktor Adam
719d4e9e20
Allow cancelling the streams from other threads
...
Signed-off-by: Viktor Adam <rycus86@gmail.com>
2018-03-20 09:25:29 +01:00
Joffrey F
90c0dbe5f8
Add test for container list with sparse=True
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-03-14 16:53:56 -07:00
Yong Tang
ab1f90a379
Cleanup containers during the tests
...
This fix tries to clean up the containers during the tests
so that no pre-existing volumes left in docker integration tests.
This fix adds `-v` when removing containers, and makes sure
containers launched in non-daemon mode are removed.
This fix is realted to moby PR 36292
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2018-02-23 15:22:42 +00:00
Yong Tang
cbbc37ac7b
Clean up created volume from test_run_with_named_volume
...
This fix adds the volume id to the list so that it could be
cleaned up on test teardown.
The issue was originally from https://github.com/moby/moby/pull/36292
where an additional `somevolume` pre-exists in tests.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2018-02-14 13:01:16 +00:00
Joffrey F
7fabcdaa4c
Update wait to always return a dict
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-01-31 16:52:26 -08:00
Joffrey F
3422211309
Use pytest asserts
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-01-30 14:26:24 -08:00
Joffrey F
6e6eaece81
Return tuple instead of dict in exec_run
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2018-01-26 14:21:23 -08:00
Joffrey F
b0cc4b5520
Merge branch 'add_exit_code_to_exec_run' of https://github.com/hnq90/docker-py into hnq90-add_exit_code_to_exec_run
2018-01-26 14:13:15 -08:00
Joffrey F
2250fa2ebd
Don't attempt to retrieve container's stderr if `auto_remove` was set
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2017-12-19 13:50:32 -08:00
Joffrey F
6b8dfe4249
Retrieve container logs before container exits / is removed
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2017-12-14 16:53:44 -08:00
HuyNQ
436306f09d
Add exit code to exec_run
...
Signed-off-by: HuyNQ <huy@huynq.net>
2017-11-13 14:11:21 +07:00
Artem Bolshakov
62fda980e4
client.containers.run returns None if none of json-file or journald logging drivers used
...
Signed-off-by: Artem Bolshakov <either.free@gmail.com>
2017-08-17 13:38:40 -07:00
Joffrey F
95297dc2e7
Replace erroneous networks argument in containers.run with singular
...
network equivalent.
Small docfixes
Signed-off-by: Joffrey F <joffrey@docker.com>
2017-05-12 14:28:27 -07:00
Ben Firshman
956fe1cac1
Fix volume path passed by run to create_container
...
Seems like this is pretty much ignored by Docker, so it wasn't
causing any visible issues, except when a volume name was used
instead of a path.
Also, added integration tests.
Ref #1380
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
2017-02-07 19:22:35 +01:00
Joffrey F
a1d550a14c
Allow configuring API version for integration test with env var
...
Signed-off-by: Joffrey F <joffrey@docker.com>
2017-01-25 16:52:26 -08:00
Ben Firshman
1984f68730
Add new user-focused API
...
See #1086
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
2016-11-22 17:05:43 +00:00