From 13b96828f2b16f4c37ac9027460ad9fa8544f337 Mon Sep 17 00:00:00 2001 From: Victor Vieux Date: Sat, 24 Jan 2015 01:40:49 +0000 Subject: [PATCH] update tests Signed-off-by: Victor Vieux --- discovery/discovery.go | 1 + discovery/discovery_test.go | 26 ++++++++++++++++++-------- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/discovery/discovery.go b/discovery/discovery.go index 91e12d30d5..1642f8412f 100644 --- a/discovery/discovery.go +++ b/discovery/discovery.go @@ -21,6 +21,7 @@ func NewNode(url string) (*Node, error) { } return &Node{host, port}, nil } + func (n Node) String() string { return fmt.Sprintf("%s:%s", n.Host, n.Port) } diff --git a/discovery/discovery_test.go b/discovery/discovery_test.go index c75b454150..ace6bc1b2c 100644 --- a/discovery/discovery_test.go +++ b/discovery/discovery_test.go @@ -6,22 +6,32 @@ import ( "github.com/stretchr/testify/assert" ) +func TestNewNode(t *testing.T) { + node, err := NewNode("127.0.0.1:2375") + assert.Equal(t, node.Host, "127.0.0.1") + assert.Equal(t, node.Port, "2375") + assert.NoError(t, err) + + _, err = NewNode("127.0.0.1") + assert.Error(t, err) +} + func TestParse(t *testing.T) { - scheme, uri := parse("127.0.0.1") + scheme, uri := parse("127.0.0.1:2375") assert.Equal(t, scheme, "nodes") - assert.Equal(t, uri, "127.0.0.1") + assert.Equal(t, uri, "127.0.0.1:2375") - scheme, uri = parse("localhost") + scheme, uri = parse("localhost:2375") assert.Equal(t, scheme, "nodes") - assert.Equal(t, uri, "localhost") + assert.Equal(t, uri, "localhost:2375") - scheme, uri = parse("scheme://127.0.0.1") + scheme, uri = parse("scheme://127.0.0.1:2375") assert.Equal(t, scheme, "scheme") - assert.Equal(t, uri, "127.0.0.1") + assert.Equal(t, uri, "127.0.0.1:2375") - scheme, uri = parse("scheme://localhost") + scheme, uri = parse("scheme://localhost:2375") assert.Equal(t, scheme, "scheme") - assert.Equal(t, uri, "localhost") + assert.Equal(t, uri, "localhost:2375") scheme, uri = parse("") assert.Equal(t, scheme, "nodes")