From 153248b60f551d4cb92bce4f35b08084f554c62c Mon Sep 17 00:00:00 2001 From: Solomon Hykes Date: Wed, 16 Oct 2013 23:23:35 +0000 Subject: [PATCH] devicemapper: remove unused code --- deviceset.go | 14 -------- devmapper/deviceset_devmapper.go | 13 ------- image.go | 3 +- runtime.go | 4 +-- utils_test.go | 59 -------------------------------- 5 files changed, 4 insertions(+), 89 deletions(-) delete mode 100644 deviceset.go diff --git a/deviceset.go b/deviceset.go deleted file mode 100644 index 21d5fd4d2f..0000000000 --- a/deviceset.go +++ /dev/null @@ -1,14 +0,0 @@ -package docker - -type DeviceSet interface { - AddDevice(hash, baseHash string) error - SetInitialized(hash string) error - DeactivateDevice(hash string) error - RemoveDevice(hash string) error - MountDevice(hash, path string) error - UnmountDevice(hash, path string, deactivate bool) error - HasDevice(hash string) bool - HasInitializedDevice(hash string) bool - HasActivatedDevice(hash string) bool - Shutdown() error -} diff --git a/devmapper/deviceset_devmapper.go b/devmapper/deviceset_devmapper.go index b778228a59..ee5c121ff9 100644 --- a/devmapper/deviceset_devmapper.go +++ b/devmapper/deviceset_devmapper.go @@ -573,19 +573,6 @@ func (devices *DeviceSetDM) waitClose(hash string) error { return nil } -func (devices *DeviceSetDM) DeactivateDevice(hash string) error { - devices.Lock() - defer devices.Unlock() - - if err := devices.ensureInit(); err != nil { - utils.Debugf("\n--->Err: %s\n", err) - return err - } - - utils.Debugf("DeactivateDevice %s", hash) - return devices.deactivateDevice(hash) -} - func (devices *DeviceSetDM) Shutdown() error { devices.Lock() utils.Debugf("[devmapper] Shutting down DeviceSet: %s", devices.root) diff --git a/image.go b/image.go index 6a1191ef1b..eead33f068 100644 --- a/image.go +++ b/image.go @@ -6,6 +6,7 @@ import ( "encoding/json" "fmt" "github.com/dotcloud/docker/utils" + "github.com/dotcloud/docker/devmapper" "io" "io/ioutil" "os" @@ -334,7 +335,7 @@ func (image *Image) applyLayer(layer, target string) error { return nil } -func (image *Image) ensureImageDevice(devices DeviceSet) error { +func (image *Image) ensureImageDevice(devices *devmapper.DeviceSetDM) error { if devices.HasInitializedDevice(image.ID) { return nil } diff --git a/runtime.go b/runtime.go index 94c8f21d20..df83e90fbe 100644 --- a/runtime.go +++ b/runtime.go @@ -43,7 +43,7 @@ type Runtime struct { volumes *Graph srv *Server Dns []string - deviceSet DeviceSet + deviceSet *devmapper.DeviceSetDM } var sysInitPath string @@ -86,7 +86,7 @@ func (runtime *Runtime) getContainerElement(id string) *list.Element { return nil } -func (runtime *Runtime) GetDeviceSet() (DeviceSet, error) { +func (runtime *Runtime) GetDeviceSet() (*devmapper.DeviceSetDM, error) { if runtime.deviceSet == nil { return nil, fmt.Errorf("No device set available") } diff --git a/utils_test.go b/utils_test.go index a7afa289dc..8d9aafbf6b 100644 --- a/utils_test.go +++ b/utils_test.go @@ -324,62 +324,3 @@ func TestParseLxcConfOpt(t *testing.T) { } } } - -type DeviceSetWrapper struct { - wrapped DeviceSet - prefix string -} - -func (wrapper *DeviceSetWrapper) wrap(hash string) string { - if hash != "" { - hash = wrapper.prefix + "-" + hash - } - return hash -} - -func (wrapper *DeviceSetWrapper) AddDevice(hash, baseHash string) error { - return wrapper.wrapped.AddDevice(wrapper.wrap(hash), wrapper.wrap(baseHash)) -} - -func (wrapper *DeviceSetWrapper) SetInitialized(hash string) error { - return wrapper.wrapped.SetInitialized(wrapper.wrap(hash)) -} - -func (wrapper *DeviceSetWrapper) DeactivateDevice(hash string) error { - return wrapper.wrapped.DeactivateDevice(wrapper.wrap(hash)) -} - -func (wrapper *DeviceSetWrapper) Shutdown() error { - return nil -} - -func (wrapper *DeviceSetWrapper) RemoveDevice(hash string) error { - return wrapper.wrapped.RemoveDevice(wrapper.wrap(hash)) -} - -func (wrapper *DeviceSetWrapper) MountDevice(hash, path string) error { - return wrapper.wrapped.MountDevice(wrapper.wrap(hash), path) -} - -func (wrapper *DeviceSetWrapper) UnmountDevice(hash, path string, deactivate bool) error { - return wrapper.wrapped.UnmountDevice(wrapper.wrap(hash), path, deactivate) -} - -func (wrapper *DeviceSetWrapper) HasDevice(hash string) bool { - return wrapper.wrapped.HasDevice(wrapper.wrap(hash)) -} - -func (wrapper *DeviceSetWrapper) HasInitializedDevice(hash string) bool { - return wrapper.wrapped.HasInitializedDevice(wrapper.wrap(hash)) -} - -func (wrapper *DeviceSetWrapper) HasActivatedDevice(hash string) bool { - return wrapper.wrapped.HasActivatedDevice(wrapper.wrap(hash)) -} - -func NewDeviceSetWrapper(wrapped DeviceSet, prefix string) DeviceSet { - return &DeviceSetWrapper{ - wrapped: wrapped, - prefix: prefix, - } -}