Merge pull request #21424 from mjbear/getting-started_part8_image

Change Docker image in part8 of getting started
This commit is contained in:
David Karlsson 2024-11-14 17:03:53 +01:00 committed by GitHub
commit 1bbd20dad1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 8 deletions

View File

@ -61,7 +61,7 @@ Look at the following Dockerfile you created for the getting started app.
```dockerfile
# syntax=docker/dockerfile:1
FROM node:18-alpine
FROM node:lts-alpine
WORKDIR /app
COPY . .
RUN yarn install --production
@ -81,7 +81,7 @@ dependencies if there was a change to the `package.json`.
```dockerfile
# syntax=docker/dockerfile:1
FROM node:18-alpine
FROM node:lts-alpine
WORKDIR /app
COPY package.json yarn.lock ./
RUN yarn install --production
@ -103,10 +103,10 @@ dependencies if there was a change to the `package.json`.
=> => transferring dockerfile: 175B
=> [internal] load .dockerignore
=> => transferring context: 2B
=> [internal] load metadata for docker.io/library/node:18-alpine
=> [internal] load metadata for docker.io/library/node:lts-alpine
=> [internal] load build context
=> => transferring context: 53.37MB
=> [1/5] FROM docker.io/library/node:18-alpine
=> [1/5] FROM docker.io/library/node:lts-alpine
=> CACHED [2/5] WORKDIR /app
=> [3/5] COPY package.json yarn.lock ./
=> [4/5] RUN yarn install --production
@ -127,10 +127,10 @@ dependencies if there was a change to the `package.json`.
=> => transferring dockerfile: 37B
=> [internal] load .dockerignore
=> => transferring context: 2B
=> [internal] load metadata for docker.io/library/node:18-alpine
=> [internal] load metadata for docker.io/library/node:lts-alpine
=> [internal] load build context
=> => transferring context: 450.43kB
=> [1/5] FROM docker.io/library/node:18-alpine
=> [1/5] FROM docker.io/library/node:lts-alpine
=> CACHED [2/5] WORKDIR /app
=> CACHED [3/5] COPY package.json yarn.lock ./
=> CACHED [4/5] RUN yarn install --production
@ -182,7 +182,7 @@ for your production build. You can ship the static resources in a static nginx c
```dockerfile
# syntax=docker/dockerfile:1
FROM node:18 AS build
FROM node:lts AS build
WORKDIR /app
COPY package* yarn.lock ./
RUN yarn install
@ -194,7 +194,7 @@ FROM nginx:alpine
COPY --from=build /app/build /usr/share/nginx/html
```
In the previous Dockerfile example, it uses the `node:18` image to perform the build (maximizing layer caching) and then copies the output
In the previous Dockerfile example, it uses the `node:lts` image to perform the build (maximizing layer caching) and then copies the output
into an nginx container.
## Summary