Merge pull request #1839 from docker/fix-windows

Fix windows connection setup and port publish

src/utils/DockerUtil.js

@@ -35,11 +35,7 @@ var DockerUtil = {
     if (ip.indexOf('local') !== -1) {
       try {
         if (util.isWindows()) {
-          this.client = new dockerode({
-            protocol: 'http',
-            host: ip,
-            port: 2375
-          });
+          this.client = new dockerode({socketPath: '//./pipe/docker_engine'});
         } else {
           this.client = new dockerode({socketPath: '/var/run/docker.sock'});
         }
@@ -157,7 +153,10 @@ var DockerUtil = {
       }
 
       if (!containerData.HostConfig || (containerData.HostConfig && !containerData.HostConfig.PortBindings)) {
-        containerData.PublishAllPorts = true;
+        if (!containerData.HostConfig) {
+          containerData.HostConfig = {};
+        }
+        containerData.HostConfig.PublishAllPorts = true;
       }
 
       if (image.Config.Cmd) {

src/utils/SetupUtil.js

@@ -91,7 +91,7 @@ export default {
     while (true) {
       try {
         router.get().transitionTo('setup');
-        docker.setup(util.isWindows() ? 'docker.local':'localhost');
+        docker.setup('localhost');
         setupServerActions.started({started: true});
         this.simulateProgress(20);
         metrics.track('Native Setup Finished');

src/utils/Util.js

@@ -43,7 +43,7 @@ module.exports = {
     if (this.native === null) {
       if (this.isWindows()) {
         this.native = http.get({
-          url: `http:////./pipe/docker_engine/v1.23/version`
+          url: `http:////./pipe/docker_engine/version`
         }, (response) => {
           if (response.statusCode !== 200 ) {
             return false;