From 29e169c2b57c34ddfed0e2dce2ebb05c122dac31 Mon Sep 17 00:00:00 2001 From: msadiq058 <42430865+msadiq058@users.noreply.github.com> Date: Thu, 3 Nov 2022 22:22:00 +0530 Subject: [PATCH] Update examples.md for golang (#16062) * Update examples.md for golang calling, `defer cli.Close()` to close the underline transport used by the client * fixed indentation * added cli.close() call in index.md Co-authored-by: Mohd Sadiq --- engine/api/sdk/examples.md | 9 +++++++++ engine/api/sdk/index.md | 1 + 2 files changed, 10 insertions(+) diff --git a/engine/api/sdk/examples.md b/engine/api/sdk/examples.md index 40812c6ea7..8cbc4f69b8 100644 --- a/engine/api/sdk/examples.md +++ b/engine/api/sdk/examples.md @@ -57,6 +57,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() reader, err := cli.ImagePull(ctx, "docker.io/library/alpine", types.ImagePullOptions{}) if err != nil { @@ -177,6 +178,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() imageName := "bfirsh/reticulate-splines" @@ -261,6 +263,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() containers, err := cli.ContainerList(ctx, types.ContainerListOptions{}) if err != nil { @@ -337,6 +340,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() containers, err := cli.ContainerList(ctx, types.ContainerListOptions{}) if err != nil { @@ -418,6 +422,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() options := types.ContainerLogsOptions{ShowStdout: true} // Replace this ID with a container that really exists @@ -488,6 +493,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() images, err := cli.ImageList(ctx, types.ImageListOptions{}) if err != nil { @@ -559,6 +565,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() out, err := cli.ImagePull(ctx, "alpine", types.ImagePullOptions{}) if err != nil { @@ -635,6 +642,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() authConfig := types.AuthConfig{ Username: "username", @@ -732,6 +740,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() createResp, err := cli.ContainerCreate(ctx, &container.Config{ Image: "alpine", diff --git a/engine/api/sdk/index.md b/engine/api/sdk/index.md index 891e0c3e80..b60e15cde2 100644 --- a/engine/api/sdk/index.md +++ b/engine/api/sdk/index.md @@ -100,6 +100,7 @@ func main() { if err != nil { panic(err) } + defer cli.Close() reader, err := cli.ImagePull(ctx, "docker.io/library/alpine", types.ImagePullOptions{}) if err != nil {