From 41bf38e44d8ef53468e76870182fa05c515a1cf5 Mon Sep 17 00:00:00 2001 From: James Turnbull Date: Tue, 4 Mar 2014 20:22:51 -0500 Subject: [PATCH 1/2] Consistently capitalize CLI options Docker-DCO-1.1-Signed-off-by: James Turnbull (github: jamtur01) --- docs/sources/reference/commandline/cli.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/sources/reference/commandline/cli.rst b/docs/sources/reference/commandline/cli.rst index f7d474bddd..ccb5314fac 100644 --- a/docs/sources/reference/commandline/cli.rst +++ b/docs/sources/reference/commandline/cli.rst @@ -527,7 +527,7 @@ For example: Show the history of an image --no-trunc=false: Don't truncate output - -q, --quiet=false: only show numeric IDs + -q, --quiet=false: Only show numeric IDs To see how the ``docker:latest`` image was built: @@ -574,11 +574,11 @@ To see how the ``docker:latest`` image was built: List images - -a, --all=false: show all images (by default filter out the intermediate images used to build) + -a, --all=false: Show all images (by default filter out the intermediate images used to build) --no-trunc=false: Don't truncate output - -q, --quiet=false: only show numeric IDs - --tree=false: output graph in tree format - --viz=false: output graph in graphviz format + -q, --quiet=false: Only show numeric IDs + --tree=false: Output graph in tree format + --viz=false: Output graph in graphviz format Listing the most recently created images ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -874,9 +874,9 @@ Known Issues (kill) Register or Login to the docker registry server - -e, --email="": email - -p, --password="": password - -u, --username="": username + -e, --email="": Email + -p, --password="": Password + -u, --username="": Username If you want to login to a private registry you can specify this by adding the server name. From 725c7cd08af5b895becce19e59fe98cebdc67cf2 Mon Sep 17 00:00:00 2001 From: James Turnbull Date: Tue, 4 Mar 2014 20:45:22 -0500 Subject: [PATCH 2/2] Made CLI option capitalization consistent in api/client.go Docker-DCO-1.1-Signed-off-by: James Turnbull (github: jamtur01) --- api/client.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/api/client.go b/api/client.go index e79452688d..9fde660776 100644 --- a/api/client.go +++ b/api/client.go @@ -233,9 +233,9 @@ func (cli *DockerCli) CmdLogin(args ...string) error { var username, password, email string - cmd.StringVar(&username, []string{"u", "-username"}, "", "username") - cmd.StringVar(&password, []string{"p", "-password"}, "", "password") - cmd.StringVar(&email, []string{"e", "-email"}, "", "email") + cmd.StringVar(&username, []string{"u", "-username"}, "", "Username") + cmd.StringVar(&password, []string{"p", "-password"}, "", "Password") + cmd.StringVar(&email, []string{"e", "-email"}, "", "Email") err := cmd.Parse(args) if err != nil { return nil @@ -831,7 +831,7 @@ func (cli *DockerCli) CmdRmi(args ...string) error { func (cli *DockerCli) CmdHistory(args ...string) error { cmd := cli.Subcmd("history", "[OPTIONS] IMAGE", "Show the history of an image") - quiet := cmd.Bool([]string{"q", "-quiet"}, false, "only show numeric IDs") + quiet := cmd.Bool([]string{"q", "-quiet"}, false, "Only show numeric IDs") noTrunc := cmd.Bool([]string{"#notrunc", "-no-trunc"}, false, "Don't truncate output") if err := cmd.Parse(args); err != nil { @@ -1102,11 +1102,11 @@ func (cli *DockerCli) CmdPull(args ...string) error { func (cli *DockerCli) CmdImages(args ...string) error { cmd := cli.Subcmd("images", "[OPTIONS] [NAME]", "List images") - quiet := cmd.Bool([]string{"q", "-quiet"}, false, "only show numeric IDs") - all := cmd.Bool([]string{"a", "-all"}, false, "show all images (by default filter out the intermediate images used to build)") + quiet := cmd.Bool([]string{"q", "-quiet"}, false, "Only show numeric IDs") + all := cmd.Bool([]string{"a", "-all"}, false, "Show all images (by default filter out the intermediate images used to build)") noTrunc := cmd.Bool([]string{"#notrunc", "-no-trunc"}, false, "Don't truncate output") - flViz := cmd.Bool([]string{"v", "#viz", "-viz"}, false, "output graph in graphviz format") - flTree := cmd.Bool([]string{"t", "#tree", "-tree"}, false, "output graph in tree format") + flViz := cmd.Bool([]string{"v", "#viz", "-viz"}, false, "Output graph in graphviz format") + flTree := cmd.Bool([]string{"t", "#tree", "-tree"}, false, "Output graph in tree format") if err := cmd.Parse(args); err != nil { return nil