mirror of https://github.com/docker/docs.git
Make nitpicky modifications
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
This commit is contained in:
parent
71140cf47c
commit
379de3acec
49
commands.go
49
commands.go
|
|
@ -161,7 +161,7 @@ func setupCertificates(caCertPath, caKeyPath, clientCertPath, clientKeyPath stri
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
var CreateFlags = []cli.Flag{
|
var sharedCreateFlags = []cli.Flag{
|
||||||
cli.StringFlag{
|
cli.StringFlag{
|
||||||
Name: "driver, d",
|
Name: "driver, d",
|
||||||
Usage: fmt.Sprintf(
|
Usage: fmt.Sprintf(
|
||||||
|
|
@ -204,7 +204,7 @@ var Commands = []cli.Command{
|
||||||
{
|
{
|
||||||
Flags: append(
|
Flags: append(
|
||||||
drivers.GetCreateFlags(),
|
drivers.GetCreateFlags(),
|
||||||
CreateFlags...,
|
sharedCreateFlags...,
|
||||||
),
|
),
|
||||||
Name: "create",
|
Name: "create",
|
||||||
Usage: "Create a machine",
|
Usage: "Create a machine",
|
||||||
|
|
@ -369,35 +369,42 @@ func cmdActive(c *cli.Context) {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// If the user has specified a driver, they should not see the flags for all
|
||||||
|
// of the drivers in `docker-machine create`. This method replaces the 100+
|
||||||
|
// create flags with only the ones applicable to the driver specified
|
||||||
|
func trimDriverFlags(driver string, cmds []cli.Command) ([]cli.Command, error) {
|
||||||
|
filteredCmds := cmds
|
||||||
|
driverFlags, err := drivers.GetCreateFlagsForDriver(driver)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
for i, cmd := range cmds {
|
||||||
|
if cmd.HasName("create") {
|
||||||
|
filteredCmds[i].Flags = append(sharedCreateFlags, driverFlags...)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return filteredCmds, nil
|
||||||
|
}
|
||||||
|
|
||||||
func cmdCreate(c *cli.Context) {
|
func cmdCreate(c *cli.Context) {
|
||||||
|
var (
|
||||||
|
err error
|
||||||
|
)
|
||||||
driver := c.String("driver")
|
driver := c.String("driver")
|
||||||
name := c.Args().First()
|
name := c.Args().First()
|
||||||
|
|
||||||
if name == "" {
|
// TODO: Not really a fan of "none" as the default driver...
|
||||||
|
if driver != "none" {
|
||||||
hasDriver := false
|
c.App.Commands, err = trimDriverFlags(driver, c.App.Commands)
|
||||||
driverFlags, err := drivers.GetCreateFlagsForDriver(driver)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
log.Fatal(err)
|
log.Fatal(err)
|
||||||
} else {
|
|
||||||
hasDriver = true
|
|
||||||
}
|
|
||||||
|
|
||||||
if hasDriver {
|
|
||||||
for i, cmd := range c.App.Commands {
|
|
||||||
if cmd.HasName("create") {
|
|
||||||
c.App.Commands[i].Flags = append(
|
|
||||||
driverFlags,
|
|
||||||
CreateFlags...,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if name == "" {
|
||||||
cli.ShowCommandHelp(c, "create")
|
cli.ShowCommandHelp(c, "create")
|
||||||
if hasDriver {
|
|
||||||
fmt.Println("Run 'docker-machine create --help' for all options.\n")
|
|
||||||
}
|
|
||||||
log.Fatal("You must specify a machine name")
|
log.Fatal("You must specify a machine name")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue