Merge pull request #388 from kitematic/better-gulp

Use minimist for parsing args in gulpfile
This commit is contained in:
Jeffrey Morgan 2015-04-17 09:54:49 -04:00
commit 477f2d7539
2 changed files with 8 additions and 9 deletions

View File

@ -17,7 +17,7 @@ var shell = require('gulp-shell');
var sourcemaps = require('gulp-sourcemaps'); var sourcemaps = require('gulp-sourcemaps');
var dependencies = Object.keys(packagejson.dependencies); var dependencies = Object.keys(packagejson.dependencies);
var isBeta = process.argv.indexOf('--beta') !== -1; var argv = require('minimist')(process.argv.slice(2));
var settings; var settings;
try { try {
@ -25,15 +25,15 @@ try {
} catch (err) { } catch (err) {
settings = {}; settings = {};
} }
settings.beta = isBeta; settings.beta = argv.beta;
var options = { var options = {
dev: process.argv.indexOf('release') === -1, dev: process.argv.indexOf('release') === -1,
beta: isBeta, beta: argv.beta,
appFilename: isBeta ? 'Kitematic (Beta).app' : 'Kitematic.app', appFilename: argv.beta ? 'Kitematic (Beta).app' : 'Kitematic.app',
appName: isBeta ? 'Kitematic (Beta)' : 'Kitematic', appName: argv.beta ? 'Kitematic (Beta)' : 'Kitematic',
name: 'Kitematic', name: 'Kitematic',
icon: isBeta ? './util/kitematic-beta.icns' : './util/kitematic.icns', icon: argv.beta ? './util/kitematic-beta.icns' : './util/kitematic.icns',
bundle: 'com.kitematic.kitematic' bundle: 'com.kitematic.kitematic'
}; };
@ -63,7 +63,6 @@ gulp.task('styles', function () {
return gulp.src('styles/main.less') return gulp.src('styles/main.less')
.pipe(plumber(function(error) { .pipe(plumber(function(error) {
gutil.log(gutil.colors.red('Error (' + error.plugin + '): ' + error.message)); gutil.log(gutil.colors.red('Error (' + error.plugin + '): ' + error.message));
// emit the end event, to properly end the task
this.emit('end'); this.emit('end');
})) }))
.pipe(gulpif(options.dev, changed('./build'))) .pipe(gulpif(options.dev, changed('./build')))

View File

@ -59,7 +59,6 @@
"dockerode": "^2.1.1", "dockerode": "^2.1.1",
"exec": "0.2.0", "exec": "0.2.0",
"jquery": "^2.1.3", "jquery": "^2.1.3",
"minimist": "^1.1.0",
"mixpanel": "0.0.20", "mixpanel": "0.0.20",
"node-uuid": "^1.4.2", "node-uuid": "^1.4.2",
"object-assign": "^2.0.0", "object-assign": "^2.0.0",
@ -74,7 +73,6 @@
}, },
"devDependencies": { "devDependencies": {
"babel": "^4.5.5", "babel": "^4.5.5",
"gulp": "^3.8.11",
"gulp-babel": "^4.0.0", "gulp-babel": "^4.0.0",
"gulp-changed": "^1.1.1", "gulp-changed": "^1.1.1",
"gulp-concat": "^2.5.2", "gulp-concat": "^2.5.2",
@ -89,8 +87,10 @@
"gulp-shell": "^0.3.0", "gulp-shell": "^0.3.0",
"gulp-sourcemaps": "^1.5.0", "gulp-sourcemaps": "^1.5.0",
"gulp-util": "^3.0.4", "gulp-util": "^3.0.4",
"gulp": "^3.8.11",
"jest-cli": "kitematic/jest", "jest-cli": "kitematic/jest",
"jsxhint": "^0.12.1", "jsxhint": "^0.12.1",
"minimist": "^1.1.0",
"react-tools": "^0.12.2", "react-tools": "^0.12.2",
"run-sequence": "^1.0.2" "run-sequence": "^1.0.2"
} }