From 4898d252ee16d7a49635efe656fa69397e90d770 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= Date: Tue, 15 Mar 2016 15:36:02 +0100 Subject: [PATCH] Don't silently ignore swizzler errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These calls can fail, and errors would cause false failures later in the tests. Signed-off-by: Miloslav Trmač --- tuf/testutils/swizzler_test.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tuf/testutils/swizzler_test.go b/tuf/testutils/swizzler_test.go index a35b5f39d6..48aae0d8a1 100644 --- a/tuf/testutils/swizzler_test.go +++ b/tuf/testutils/swizzler_test.go @@ -159,7 +159,8 @@ func TestSwizzlerSetInvalidSigned(t *testing.T) { func TestSwizzlerSetInvalidSignedMeta(t *testing.T) { f, origMeta := createNewSwizzler(t) - f.SetInvalidSignedMeta(data.CanonicalRootRole) + err := f.SetInvalidSignedMeta(data.CanonicalRootRole) + require.NoError(t, err) for role, metaBytes := range origMeta { newMeta, err := f.MetadataCache.GetMeta(role, -1) @@ -306,7 +307,8 @@ func TestSwizzlerOffsetMetadataVersion(t *testing.T) { func TestSwizzlerExpireMetadata(t *testing.T) { f, origMeta := createNewSwizzler(t) - f.ExpireMetadata(data.CanonicalRootRole) + err := f.ExpireMetadata(data.CanonicalRootRole) + require.NoError(t, err) for role, metaBytes := range origMeta { newMeta, err := f.MetadataCache.GetMeta(role, -1) @@ -330,7 +332,8 @@ func TestSwizzlerExpireMetadata(t *testing.T) { func TestSwizzlerSetThresholdBaseRole(t *testing.T) { f, origMeta := createNewSwizzler(t) - f.SetThreshold(data.CanonicalTargetsRole, 3) + err := f.SetThreshold(data.CanonicalTargetsRole, 3) + require.NoError(t, err) for role, metaBytes := range origMeta { newMeta, err := f.MetadataCache.GetMeta(role, -1) @@ -382,7 +385,8 @@ func TestSwizzlerSetThresholdDelegatedRole(t *testing.T) { func TestSwizzlerChangeRootKey(t *testing.T) { f, origMeta := createNewSwizzler(t) - f.ChangeRootKey() + err := f.ChangeRootKey() + require.NoError(t, err) tufRepo := tuf.NewRepo(f.CryptoService)