From 88afbc4d94c4a803e936d602c620b8ab08e24acd Mon Sep 17 00:00:00 2001
From: Doug Davis <dug@us.ibm.com>
Date: Sat, 22 Nov 2014 05:25:57 -0800
Subject: [PATCH] Add missing unit testcase for new IsSet() func in mflag
Forgot to add this when I did PR #9259
Signed-off-by: Doug Davis <dug@us.ibm.com>
---
pkg/mflag/flag_test.go | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/pkg/mflag/flag_test.go b/pkg/mflag/flag_test.go
index 340a1cb175..622e8a9bfc 100644
--- a/pkg/mflag/flag_test.go
+++ b/pkg/mflag/flag_test.go
@@ -168,11 +168,14 @@ func testParse(f *FlagSet, t *testing.T) {
}
boolFlag := f.Bool([]string{"bool"}, false, "bool value")
bool2Flag := f.Bool([]string{"bool2"}, false, "bool2 value")
+ f.Bool([]string{"bool3"}, false, "bool3 value")
+ bool4Flag := f.Bool([]string{"bool4"}, false, "bool4 value")
intFlag := f.Int([]string{"-int"}, 0, "int value")
int64Flag := f.Int64([]string{"-int64"}, 0, "int64 value")
uintFlag := f.Uint([]string{"uint"}, 0, "uint value")
uint64Flag := f.Uint64([]string{"-uint64"}, 0, "uint64 value")
stringFlag := f.String([]string{"string"}, "0", "string value")
+ f.String([]string{"string2"}, "0", "string2 value")
singleQuoteFlag := f.String([]string{"squote"}, "", "single quoted value")
doubleQuoteFlag := f.String([]string{"dquote"}, "", "double quoted value")
mixedQuoteFlag := f.String([]string{"mquote"}, "", "mixed quoted value")
@@ -185,6 +188,7 @@ func testParse(f *FlagSet, t *testing.T) {
args := []string{
"-bool",
"-bool2=true",
+ "-bool4=false",
"--int", "22",
"--int64", "0x23",
"-uint", "24",
@@ -212,6 +216,18 @@ func testParse(f *FlagSet, t *testing.T) {
if *bool2Flag != true {
t.Error("bool2 flag should be true, is ", *bool2Flag)
}
+ if !f.IsSet("bool2") {
+ t.Error("bool2 should be marked as set")
+ }
+ if f.IsSet("bool3") {
+ t.Error("bool3 should not be marked as set")
+ }
+ if !f.IsSet("bool4") {
+ t.Error("bool4 should be marked as set")
+ }
+ if *bool4Flag != false {
+ t.Error("bool4 flag should be false, is ", *bool4Flag)
+ }
if *intFlag != 22 {
t.Error("int flag should be 22, is ", *intFlag)
}
@@ -227,6 +243,12 @@ func testParse(f *FlagSet, t *testing.T) {
if *stringFlag != "hello" {
t.Error("string flag should be `hello`, is ", *stringFlag)
}
+ if !f.IsSet("string") {
+ t.Error("string flag should be marked as set")
+ }
+ if f.IsSet("string2") {
+ t.Error("string2 flag should not be marked as set")
+ }
if *singleQuoteFlag != "single" {
t.Error("single quote string flag should be `single`, is ", *singleQuoteFlag)
}