docker
/
docs
mirror of https://github.com/docker/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vbox: fix race with getting a tcp port 

Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
This commit is contained in:
Evan Hazlett 2015-03-19 15:30:02 -04:00
parent 407f75d109
commit 4e10204b8e
No known key found for this signature in database
GPG Key ID: A519480096146526
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/virtualbox/virtualbox.go
View File

@ -628,15 +628,25 @@ func zeroFill(w io.Writer, n int64) error {
} }
func getAvailableTCPPort() (int, error) { func getAvailableTCPPort() (int, error) {
// FIXME: this has a race condition between finding an available port and port := 0
// virtualbox using that port. Perhaps we should randomly pick an unused for {
// port in a range not used by kernel for assigning ports ln, err := net.Listen("tcp4", "127.0.0.1:0")
ln, err := net.Listen("tcp4", "127.0.0.1:0") if err != nil {
if err != nil { return 0, err
return 0, err }
defer ln.Close()
addr := ln.Addr().String()
addrParts := strings.SplitN(addr, ":", 2)
p, err := strconv.Atoi(addrParts[1])
if err != nil {
return 0, err
}
if p != 0 {
port = p
break
}
time.Sleep(1)
} }
defer ln.Close()
addr := ln.Addr().String() return port, nil
addrParts := strings.SplitN(addr, ":", 2)
return strconv.Atoi(addrParts[1])
} }