From 42076c9a3690317e83004e0743690450e0d3ae27 Mon Sep 17 00:00:00 2001 From: Mark Goho Date: Tue, 16 Mar 2021 14:10:19 -0400 Subject: [PATCH] fix username for tagged image in github actions the username is hardcoded, but should use the same secret from the first step --- language/nodejs/configure-ci-cd.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/language/nodejs/configure-ci-cd.md b/language/nodejs/configure-ci-cd.md index e2406d2ff5..7e0c23e3c2 100644 --- a/language/nodejs/configure-ci-cd.md +++ b/language/nodejs/configure-ci-cd.md @@ -100,7 +100,7 @@ Now, we can add the steps required. The first one checks-out our repository unde context: ./ file: ./Dockerfile push: true - tags: ushamandya/simplewhale:latest + tags: ${{ secrets.DOCKER_HUB_USERNAME }}/simplewhale:latest - name: Image digest run: echo ${{ steps.docker_build.outputs.digest }} @@ -153,7 +153,7 @@ Using the cache we set up earlier for it to store to and to retrieve file: ./Dockerfile builder: ${{ steps.buildx.outputs.name }} push: true - tags: ushamandya/simplewhale:latest + tags: ${{ secrets.DOCKER_HUB_USERNAME }}/simplewhale:latest cache-from: type=local,src=/tmp/.buildx-cache cache-to: type=local,dest=/tmp/.buildx-cache - name: Image digest