diff --git a/integration-cli/docker_api_containers_test.go b/integration-cli/docker_api_containers_test.go index 9ca2ebc86b..d48b945724 100644 --- a/integration-cli/docker_api_containers_test.go +++ b/integration-cli/docker_api_containers_test.go @@ -4,6 +4,7 @@ import ( "bytes" "encoding/json" "io" + "net/http" "os/exec" "strings" "testing" @@ -134,7 +135,7 @@ func TestContainerApiStartVolumeBinds(t *testing.T) { "Volumes": map[string]struct{}{"/tmp": {}}, } - if _, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && !strings.Contains(err.Error(), "201 Created") { + if status, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && status != http.StatusCreated { t.Fatal(err) } @@ -142,7 +143,7 @@ func TestContainerApiStartVolumeBinds(t *testing.T) { config = map[string]interface{}{ "Binds": []string{bindPath + ":/tmp"}, } - if _, _, err := sockRequest("POST", "/containers/"+name+"/start", config); err != nil && !strings.Contains(err.Error(), "204 No Content") { + if status, _, err := sockRequest("POST", "/containers/"+name+"/start", config); err != nil && status != http.StatusNoContent { t.Fatal(err) } @@ -167,7 +168,7 @@ func TestContainerApiStartDupVolumeBinds(t *testing.T) { "Volumes": map[string]struct{}{"/tmp": {}}, } - if _, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && !strings.Contains(err.Error(), "201 Created") { + if status, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && status != http.StatusCreated { t.Fatal(err) } @@ -202,14 +203,14 @@ func TestContainerApiStartVolumesFrom(t *testing.T) { "Volumes": map[string]struct{}{volPath: {}}, } - if _, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && !strings.Contains(err.Error(), "201 Created") { + if status, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && status != http.StatusCreated { t.Fatal(err) } config = map[string]interface{}{ "VolumesFrom": []string{volName}, } - if _, _, err := sockRequest("POST", "/containers/"+name+"/start", config); err != nil && !strings.Contains(err.Error(), "204 No Content") { + if status, _, err := sockRequest("POST", "/containers/"+name+"/start", config); err != nil && status != http.StatusNoContent { t.Fatal(err) } @@ -246,7 +247,7 @@ func TestVolumesFromHasPriority(t *testing.T) { "Volumes": map[string]struct{}{volPath: {}}, } - if _, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && !strings.Contains(err.Error(), "201 Created") { + if status, _, err := sockRequest("POST", "/containers/create?name="+name, config); err != nil && status != http.StatusCreated { t.Fatal(err) } @@ -255,7 +256,7 @@ func TestVolumesFromHasPriority(t *testing.T) { "VolumesFrom": []string{volName}, "Binds": []string{bindPath + ":/tmp"}, } - if _, _, err := sockRequest("POST", "/containers/"+name+"/start", config); err != nil && !strings.Contains(err.Error(), "204 No Content") { + if status, _, err := sockRequest("POST", "/containers/"+name+"/start", config); err != nil && status != http.StatusNoContent { t.Fatal(err) } @@ -538,8 +539,7 @@ func TestPostContainerBindNormalVolume(t *testing.T) { } bindSpec := map[string][]string{"Binds": {fooDir + ":/foo"}} - _, _, err = sockRequest("POST", "/containers/two/start", bindSpec) - if err != nil && !strings.Contains(err.Error(), "204 No Content") { + if status, _, err := sockRequest("POST", "/containers/two/start", bindSpec); err != nil && status != http.StatusNoContent { t.Fatal(err) } @@ -566,7 +566,7 @@ func TestContainerApiPause(t *testing.T) { } ContainerID := strings.TrimSpace(out) - if _, _, err = sockRequest("POST", "/containers/"+ContainerID+"/pause", nil); err != nil && !strings.Contains(err.Error(), "204 No Content") { + if status, _, err := sockRequest("POST", "/containers/"+ContainerID+"/pause", nil); err != nil && status != http.StatusNoContent { t.Fatalf("POST a container pause: sockRequest failed: %v", err) } @@ -580,7 +580,7 @@ func TestContainerApiPause(t *testing.T) { t.Fatalf("there should be one paused container and not %d", len(pausedContainers)) } - if _, _, err = sockRequest("POST", "/containers/"+ContainerID+"/unpause", nil); err != nil && !strings.Contains(err.Error(), "204 No Content") { + if status, _, err := sockRequest("POST", "/containers/"+ContainerID+"/unpause", nil); err != nil && status != http.StatusNoContent { t.Fatalf("POST a container pause: sockRequest failed: %v", err) } diff --git a/integration-cli/docker_cli_rm_test.go b/integration-cli/docker_cli_rm_test.go index 56eb2e5252..5f9a5dda57 100644 --- a/integration-cli/docker_cli_rm_test.go +++ b/integration-cli/docker_cli_rm_test.go @@ -1,6 +1,7 @@ package main import ( + "net/http" "os" "os/exec" "strings" @@ -64,12 +65,11 @@ func TestRmRunningContainerCheckError409(t *testing.T) { createRunningContainer(t, "foo") endpoint := "/containers/foo" - _, _, err := sockRequest("DELETE", endpoint, nil) + status, _, err := sockRequest("DELETE", endpoint, nil) if err == nil { t.Fatalf("Expected error, can't rm a running container") - } - if !strings.Contains(err.Error(), "409 Conflict") { + } else if status != http.StatusConflict { t.Fatalf("Expected error to contain '409 Conflict' but found %s", err) }