From 5f4583bd3fc08248250cc81e3032614e2a03fe27 Mon Sep 17 00:00:00 2001 From: Jean-Laurent de Morlhon Date: Fri, 11 Dec 2015 11:01:24 +0100 Subject: [PATCH] Add context, driver name & command to crash report Signed-off-by: Jean-Laurent de Morlhon --- libmachine/crashreport/crash_report.go | 4 ++-- libmachine/host/host.go | 4 ++-- libmachine/libmachine.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libmachine/crashreport/crash_report.go b/libmachine/crashreport/crash_report.go index ae2c05ca15..fdbb0ae47f 100644 --- a/libmachine/crashreport/crash_report.go +++ b/libmachine/crashreport/crash_report.go @@ -40,7 +40,7 @@ func Configure(key string) { } // Send through http the crash report to bugsnag need a call to Configure(apiKey) before -func Send(error error) error { +func Send(err error, context string, driverName string, command string) error { if noReportFileExist() { err := errors.New("Not sending report since the optout file exist.") log.Debug(err) @@ -79,7 +79,7 @@ func Send(error error) error { buffer.WriteString(message + "\n") } metaData.Add("history", "trace", buffer.String()) - return bugsnag.Notify(error, metaData) + return bugsnag.Notify(err, metaData, bugsnag.SeverityError, bugsnag.Context{String: context}, bugsnag.ErrorClass{Name: fmt.Sprintf("%s/%s", driverName, command)}) } func noReportFileExist() bool { diff --git a/libmachine/host/host.go b/libmachine/host/host.go index 2142d837f3..5492e85d86 100644 --- a/libmachine/host/host.go +++ b/libmachine/host/host.go @@ -135,13 +135,13 @@ func (h *Host) Upgrade() error { provisioner, err := provision.DetectProvisioner(h.Driver) if err != nil { - crashreport.Send(err) + crashreport.Send(err, "provision.DetectProvisioner", h.Driver.DriverName(), "Upgrade") return err } log.Info("Upgrading docker...") if err := provisioner.Package("docker", pkgaction.Upgrade); err != nil { - crashreport.Send(err) + crashreport.Send(err, "provisioner.Package", h.Driver.DriverName(), "Upgrade") return err } diff --git a/libmachine/libmachine.go b/libmachine/libmachine.go index 7dd8464e41..566bedbe63 100644 --- a/libmachine/libmachine.go +++ b/libmachine/libmachine.go @@ -98,7 +98,7 @@ func (api *Client) Create(h *host.Host) error { log.Info("Creating machine...") if err := api.performCreate(h); err != nil { - crashreport.Send(err) + crashreport.Send(err, "api.performCreate", h.DriverName, "Create") return err }