From 54da339b2c3d1fe11a465aff69fc4e00ec3b40fd Mon Sep 17 00:00:00 2001 From: Johan Euphrosine Date: Fri, 28 Jun 2013 12:41:09 -0700 Subject: [PATCH] api,server: slice are already refs, no need to return ptr --- api.go | 2 +- server.go | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/api.go b/api.go index de4113231c..4a8605856f 100644 --- a/api.go +++ b/api.go @@ -535,7 +535,7 @@ func deleteImages(srv *Server, version float64, w http.ResponseWriter, r *http.R return err } if imgs != nil { - if len(*imgs) != 0 { + if len(imgs) != 0 { b, err := json.Marshal(imgs) if err != nil { return err diff --git a/server.go b/server.go index cdc01c6b09..f2f372efc5 100644 --- a/server.go +++ b/server.go @@ -858,7 +858,7 @@ func (srv *Server) deleteImageParents(img *Image, imgs *[]APIRmi) error { return nil } -func (srv *Server) deleteImage(img *Image, repoName, tag string) (*[]APIRmi, error) { +func (srv *Server) deleteImage(img *Image, repoName, tag string) ([]APIRmi, error) { //Untag the current image var imgs []APIRmi tagDeleted, err := srv.runtime.repositories.Delete(repoName, tag) @@ -871,18 +871,18 @@ func (srv *Server) deleteImage(img *Image, repoName, tag string) (*[]APIRmi, err if len(srv.runtime.repositories.ByID()[img.ID]) == 0 { if err := srv.deleteImageAndChildren(img.ID, &imgs); err != nil { if err != ErrImageReferenced { - return &imgs, err + return imgs, err } } else if err := srv.deleteImageParents(img, &imgs); err != nil { if err != ErrImageReferenced { - return &imgs, err + return imgs, err } } } - return &imgs, nil + return imgs, nil } -func (srv *Server) ImageDelete(name string, autoPrune bool) (*[]APIRmi, error) { +func (srv *Server) ImageDelete(name string, autoPrune bool) ([]APIRmi, error) { img, err := srv.runtime.repositories.LookupImage(name) if err != nil { return nil, fmt.Errorf("No such image: %s", name)