docker
/
docs
mirror of https://github.com/docker/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Minor edits for clarification
This commit is contained in:
Dockertopia 2022-09-01 17:02:21 +01:00 committed by GitHub
parent cf142d7bd4
commit 56433afce6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
compose/compose-file/index.md
View File

@ -2062,8 +2062,7 @@ Compose implementations MUST set `com.docker.compose.project` and `com.docker.co
If set to `true`, `external` specifies that this network’s lifecycle is maintained outside of that of the application.
Compose Implementations SHOULD NOT attempt to create these networks, and raises an error if one doesn't exist.
If `external` is set to `true` and network configuration has other but `name` attributes set, considering resource is
not managed by compose lifecycle, Compose Implementations SHOULD reject a Compose file as invalid.
If `external` is set to `true` , then the resource is not managed by Compose. If `external` is set to `true` and the network configuration has other attributes set besides `name`, then Compose Implementations SHOULD reject the Compose file as invalid.
In the example below, `proxy` is the gateway to the outside world. Instead of attempting to create a network, Compose
implementations SHOULD interrogate the platform for an existing network simply called `outside` and connect the
@ -2163,8 +2162,7 @@ If set to `true`, `external` specifies that this volume already exist on the pla
of that of the application. Compose implementations MUST NOT attempt to create these volumes, and MUST return an error if they
do not exist.
If `external` is set to `true` and volume configuration has other but `name` attributes set, considering resource is
not managed by compose lifecycle, Compose Implementations SHOULD reject a Compose file as invalid.
If `external` is set to `true` , then the resource is not managed by Compose. If `external` is set to `true` and the network configuration has other attributes set besides `name`, then Compose Implementations SHOULD reject the Compose file as invalid.
In the example below, instead of attempting to create a volume called
@ -2291,8 +2289,7 @@ configs:
name: "${HTTP_CONFIG_KEY}"
```
If `external` is set to `true` and secret configuration has other but `name` attributes set, considering resource is
not managed by compose lifecycle, Compose Implementations SHOULD reject a Compose file as invalid.
If `external` is set to `true` , then the resource is not managed by Compose. If `external` is set to `true` and the network configuration has other attributes set besides `name`, then Compose Implementations SHOULD reject the Compose file as invalid.
Compose file need to explicitly grant access to the configs to relevant services in the application.
@ -2349,9 +2346,7 @@ secrets:
name: "${CERTIFICATE_KEY}"
```
If `external` is set to `true` and secret configuration has other but `name` attributes set, considering resource is
not managed by compose lifecycle, Compose Implementations SHOULD reject a Compose file as invalid.
If `external` is set to `true` , then the resource is not managed by Compose. If `external` is set to `true` and the network configuration has other attributes set besides `name`, then Compose Implementations SHOULD reject the Compose file as invalid.
Compose file need to explicitly grant access to the secrets to relevant services in the application.
## Fragments