docker
/
docs
mirror of https://github.com/docker/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Suggest passing --no-log-init to adduser (#3413) 

Running `useradd` without `--no-log-init` risks triggering a resource exhaustion issue:

    https://github.com/moby/moby/issues/15585
    https://github.com/moby/moby/issues/5419
    https://github.com/golang/go/issues/13548
This commit is contained in:
memory 2017-06-02 09:55:36 -07:00 committed by Misty Stanley-Jones
parent 40db188f3f
commit 571d2354c8
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
engine/userguide/eng-image/dockerfile_best-practices.md
View File

@ -513,12 +513,20 @@ parts of your image.
If a service can run without privileges, use `USER` to change to a non-root If a service can run without privileges, use `USER` to change to a non-root
user. Start by creating the user and group in the `Dockerfile` with something user. Start by creating the user and group in the `Dockerfile` with something
like `RUN groupadd -r postgres && useradd -r -g postgres postgres`. like `RUN groupadd -r postgres && useradd --no-log-init -r -g postgres postgres`.
> **Note**: Users and groups in an image get a non-deterministic > **Note**: Users and groups in an image get a non-deterministic
> UID/GID in that the “next” UID/GID gets assigned regardless of image > UID/GID in that the “next” UID/GID gets assigned regardless of image
> rebuilds. So, if it’s critical, you should assign an explicit UID/GID. > rebuilds. So, if it’s critical, you should assign an explicit UID/GID.
> **Note**: Due to an [unresolved bug](https://github.com/golang/go/issues/13548)
> in the Go archive/tar package's handling of sparse files, attempting to
> create a user with a sufficiently large UID inside a Docker container can
> lead to disk exhaustion as `/var/log/faillog` in the container layer is
> filled with NUL (\0) characters. Passing the `--no-log-init` flag to
> useradd works around this issue. The Debian/Ubuntu `adduser` wrapper
> does not support the `--no-log-init` flag and should be avoided.
You should avoid installing or using `sudo` since it has unpredictable TTY and You should avoid installing or using `sudo` since it has unpredictable TTY and
signal-forwarding behavior that can cause more problems than it solves. If signal-forwarding behavior that can cause more problems than it solves. If
you absolutely need functionality similar to `sudo` (e.g., initializing the you absolutely need functionality similar to `sudo` (e.g., initializing the