diff --git a/.gitignore b/.gitignore index 017d50aef3..54e7d0d574 100644 --- a/.gitignore +++ b/.gitignore @@ -36,3 +36,4 @@ man/man5 man/man8 pyenv vendor/pkg/ +version/version_autogen.go diff --git a/api/client/hijack.go b/api/client/hijack.go index 5b8a23c7ac..7908bd6ea5 100644 --- a/api/client/hijack.go +++ b/api/client/hijack.go @@ -15,9 +15,9 @@ import ( "github.com/Sirupsen/logrus" "github.com/docker/docker/api" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/pkg/stdcopy" "github.com/docker/docker/pkg/term" + "github.com/docker/docker/version" ) type tlsClientCon struct { @@ -152,7 +152,7 @@ func (cli *DockerCli) hijackWithContentType(method, path, contentType string, se req.Header.Set(k, v) } - req.Header.Set("User-Agent", "Docker-Client/"+dockerversion.VERSION+" ("+runtime.GOOS+")") + req.Header.Set("User-Agent", "Docker-Client/"+version.VERSION+" ("+runtime.GOOS+")") req.Header.Set("Content-Type", contentType) req.Header.Set("Connection", "Upgrade") req.Header.Set("Upgrade", "tcp") diff --git a/api/client/utils.go b/api/client/utils.go index 9eeb0eb045..590649b4df 100644 --- a/api/client/utils.go +++ b/api/client/utils.go @@ -20,7 +20,6 @@ import ( "github.com/Sirupsen/logrus" "github.com/docker/docker/api" "github.com/docker/docker/api/types" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/cliconfig" "github.com/docker/docker/pkg/jsonmessage" "github.com/docker/docker/pkg/signal" @@ -28,6 +27,7 @@ import ( "github.com/docker/docker/pkg/term" "github.com/docker/docker/registry" "github.com/docker/docker/utils" + "github.com/docker/docker/version" ) var ( @@ -77,7 +77,7 @@ func (cli *DockerCli) clientRequest(method, path string, in io.Reader, headers m req.Header.Set(k, v) } - req.Header.Set("User-Agent", "Docker-Client/"+dockerversion.VERSION+" ("+runtime.GOOS+")") + req.Header.Set("User-Agent", "Docker-Client/"+version.VERSION+" ("+runtime.GOOS+")") req.URL.Host = cli.addr req.URL.Scheme = cli.scheme diff --git a/api/client/version.go b/api/client/version.go index 43cde71ec4..786857eade 100644 --- a/api/client/version.go +++ b/api/client/version.go @@ -7,10 +7,10 @@ import ( "github.com/docker/docker/api" "github.com/docker/docker/api/types" - "github.com/docker/docker/autogen/dockerversion" Cli "github.com/docker/docker/cli" flag "github.com/docker/docker/pkg/mflag" "github.com/docker/docker/utils" + "github.com/docker/docker/version" ) var versionTemplate = `Client: @@ -60,11 +60,11 @@ func (cli *DockerCli) CmdVersion(args ...string) (err error) { vd := versionData{ Client: types.Version{ - Version: dockerversion.VERSION, + Version: version.VERSION, APIVersion: api.Version, GoVersion: runtime.Version(), - GitCommit: dockerversion.GITCOMMIT, - BuildTime: dockerversion.BUILDTIME, + GitCommit: version.GITCOMMIT, + BuildTime: version.BUILDTIME, Os: runtime.GOOS, Arch: runtime.GOARCH, Experimental: utils.ExperimentalBuild(), diff --git a/api/server/middleware.go b/api/server/middleware.go index 7581adee58..718d8c3a8c 100644 --- a/api/server/middleware.go +++ b/api/server/middleware.go @@ -11,9 +11,9 @@ import ( "github.com/Sirupsen/logrus" "github.com/docker/docker/api" "github.com/docker/docker/api/server/httputils" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/errors" "github.com/docker/docker/pkg/version" + dockerversion "github.com/docker/docker/version" "golang.org/x/net/context" ) diff --git a/api/server/router/local/info.go b/api/server/router/local/info.go index 9b87f5ae7c..d916f4d9ff 100644 --- a/api/server/router/local/info.go +++ b/api/server/router/local/info.go @@ -10,24 +10,24 @@ import ( "github.com/docker/docker/api" "github.com/docker/docker/api/server/httputils" "github.com/docker/docker/api/types" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/pkg/ioutils" "github.com/docker/docker/pkg/jsonmessage" "github.com/docker/docker/pkg/parsers/filters" "github.com/docker/docker/pkg/parsers/kernel" "github.com/docker/docker/utils" + "github.com/docker/docker/version" "golang.org/x/net/context" ) func (s *router) getVersion(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error { v := &types.Version{ - Version: dockerversion.VERSION, + Version: version.VERSION, APIVersion: api.Version, - GitCommit: dockerversion.GITCOMMIT, + GitCommit: version.GITCOMMIT, GoVersion: runtime.Version(), Os: runtime.GOOS, Arch: runtime.GOARCH, - BuildTime: dockerversion.BUILDTIME, + BuildTime: version.BUILDTIME, } version := httputils.VersionFromContext(ctx) diff --git a/daemon/daemon_unix.go b/daemon/daemon_unix.go index c94ea49b52..7fe4f60f1e 100644 --- a/daemon/daemon_unix.go +++ b/daemon/daemon_unix.go @@ -12,7 +12,6 @@ import ( "syscall" "github.com/Sirupsen/logrus" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/daemon/graphdriver" derr "github.com/docker/docker/errors" "github.com/docker/docker/pkg/fileutils" @@ -22,6 +21,7 @@ import ( "github.com/docker/docker/pkg/sysinfo" "github.com/docker/docker/runconfig" "github.com/docker/docker/utils" + "github.com/docker/docker/version" "github.com/docker/docker/volume" "github.com/docker/libnetwork" nwconfig "github.com/docker/libnetwork/config" @@ -286,7 +286,7 @@ func migrateIfDownlevel(driver graphdriver.Driver, root string) error { } func configureSysInit(config *Config, rootUID, rootGID int) (string, error) { - localCopy := filepath.Join(config.Root, "init", fmt.Sprintf("dockerinit-%s", dockerversion.VERSION)) + localCopy := filepath.Join(config.Root, "init", fmt.Sprintf("dockerinit-%s", version.VERSION)) sysInitPath := utils.DockerInitPath(localCopy) if sysInitPath == "" { return "", fmt.Errorf("Could not locate dockerinit: This usually means docker was built incorrectly. See https://docs.docker.com/project/set-up-dev-env/ for official build instructions.") diff --git a/daemon/execdriver/windows/windows.go b/daemon/execdriver/windows/windows.go index a1f4f48ae3..9e269c59ea 100644 --- a/daemon/execdriver/windows/windows.go +++ b/daemon/execdriver/windows/windows.go @@ -8,9 +8,9 @@ import ( "sync" "github.com/Sirupsen/logrus" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/daemon/execdriver" "github.com/docker/docker/pkg/parsers" + "github.com/docker/docker/version" ) // This is a daemon development variable only and should not be @@ -24,7 +24,7 @@ var forceKill bool // Define name and version for windows var ( DriverName = "Windows 1854" - Version = dockerversion.VERSION + " " + dockerversion.GITCOMMIT + Version = version.VERSION + " " + version.GITCOMMIT ) type activeContainer struct { diff --git a/daemon/graphdriver/windows/windows.go b/daemon/graphdriver/windows/windows.go index dbd3defd5c..23f9e48552 100644 --- a/daemon/graphdriver/windows/windows.go +++ b/daemon/graphdriver/windows/windows.go @@ -16,7 +16,6 @@ import ( "time" "github.com/Sirupsen/logrus" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/daemon/graphdriver" "github.com/docker/docker/image" "github.com/docker/docker/pkg/archive" @@ -24,6 +23,7 @@ import ( "github.com/docker/docker/pkg/idtools" "github.com/docker/docker/pkg/ioutils" "github.com/docker/docker/pkg/random" + "github.com/docker/docker/version" "github.com/microsoft/hcsshim" ) @@ -440,7 +440,7 @@ func (d *Driver) RestoreCustomImages(tagger graphdriver.Tagger, recorder graphdr img := &image.Image{ ID: id, Created: imageData.CreatedTime, - DockerVersion: dockerversion.VERSION, + DockerVersion: version.VERSION, Architecture: runtime.GOARCH, OS: runtime.GOOS, Size: imageData.Size, diff --git a/daemon/info.go b/daemon/info.go index f977f69700..83be0f0eca 100644 --- a/daemon/info.go +++ b/daemon/info.go @@ -7,7 +7,6 @@ import ( "github.com/Sirupsen/logrus" "github.com/docker/docker/api/types" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/pkg/fileutils" "github.com/docker/docker/pkg/parsers/kernel" "github.com/docker/docker/pkg/parsers/operatingsystem" @@ -15,6 +14,7 @@ import ( "github.com/docker/docker/pkg/system" "github.com/docker/docker/registry" "github.com/docker/docker/utils" + "github.com/docker/docker/version" ) // SystemInfo returns information about the host server the daemon is running on. @@ -83,14 +83,14 @@ func (daemon *Daemon) SystemInfo() (*types.Info, error) { OperatingSystem: operatingSystem, IndexServerAddress: registry.IndexServer, RegistryConfig: daemon.RegistryService.Config, - InitSha1: dockerversion.INITSHA1, + InitSha1: version.INITSHA1, InitPath: initPath, NCPU: runtime.NumCPU(), MemTotal: meminfo.MemTotal, DockerRootDir: daemon.config().Root, Labels: daemon.config().Labels, ExperimentalBuild: utils.ExperimentalBuild(), - ServerVersion: dockerversion.VERSION, + ServerVersion: version.VERSION, ClusterStore: daemon.config().ClusterStore, ClusterAdvertise: daemon.config().ClusterAdvertise, } diff --git a/docker/daemon.go b/docker/daemon.go index fb68e70544..d97986a5fb 100644 --- a/docker/daemon.go +++ b/docker/daemon.go @@ -14,7 +14,6 @@ import ( "github.com/Sirupsen/logrus" "github.com/docker/distribution/uuid" apiserver "github.com/docker/docker/api/server" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/cli" "github.com/docker/docker/cliconfig" "github.com/docker/docker/daemon" @@ -28,6 +27,7 @@ import ( "github.com/docker/docker/pkg/tlsconfig" "github.com/docker/docker/registry" "github.com/docker/docker/utils" + "github.com/docker/docker/version" ) const daemonUsage = " docker daemon [ --help | ... ]\n" @@ -206,7 +206,7 @@ func (cli *DaemonCli) CmdDaemon(args ...string) error { serverConfig := &apiserver.Config{ Logging: true, - Version: dockerversion.VERSION, + Version: version.VERSION, } serverConfig = setPlatformServerConfig(serverConfig, cli.Config) @@ -279,8 +279,8 @@ func (cli *DaemonCli) CmdDaemon(args ...string) error { logrus.Info("Daemon has completed initialization") logrus.WithFields(logrus.Fields{ - "version": dockerversion.VERSION, - "commit": dockerversion.GITCOMMIT, + "version": version.VERSION, + "commit": version.GITCOMMIT, "execdriver": d.ExecutionDriver().Name(), "graphdriver": d.GraphDriver().String(), }).Info("Docker daemon") diff --git a/docker/docker.go b/docker/docker.go index 4795b8046d..90b1e9e4e0 100644 --- a/docker/docker.go +++ b/docker/docker.go @@ -6,12 +6,12 @@ import ( "github.com/Sirupsen/logrus" "github.com/docker/docker/api/client" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/cli" flag "github.com/docker/docker/pkg/mflag" "github.com/docker/docker/pkg/reexec" "github.com/docker/docker/pkg/term" "github.com/docker/docker/utils" + "github.com/docker/docker/version" ) func main() { @@ -77,8 +77,8 @@ func main() { func showVersion() { if utils.ExperimentalBuild() { - fmt.Printf("Docker version %s, build %s, experimental\n", dockerversion.VERSION, dockerversion.GITCOMMIT) + fmt.Printf("Docker version %s, build %s, experimental\n", version.VERSION, version.GITCOMMIT) } else { - fmt.Printf("Docker version %s, build %s\n", dockerversion.VERSION, dockerversion.GITCOMMIT) + fmt.Printf("Docker version %s, build %s\n", version.VERSION, version.GITCOMMIT) } } diff --git a/graph/graph.go b/graph/graph.go index ce84c0c348..8f77f8f6aa 100644 --- a/graph/graph.go +++ b/graph/graph.go @@ -17,7 +17,6 @@ import ( "github.com/Sirupsen/logrus" "github.com/docker/distribution/digest" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/daemon/graphdriver" "github.com/docker/docker/image" "github.com/docker/docker/pkg/archive" @@ -27,6 +26,7 @@ import ( "github.com/docker/docker/pkg/stringid" "github.com/docker/docker/pkg/truncindex" "github.com/docker/docker/runconfig" + "github.com/docker/docker/version" "github.com/vbatts/tar-split/tar/asm" "github.com/vbatts/tar-split/tar/storage" ) @@ -247,7 +247,7 @@ func (graph *Graph) Create(layerData io.Reader, containerID, containerImage, com ID: stringid.GenerateRandomID(), Comment: comment, Created: time.Now().UTC(), - DockerVersion: dockerversion.VERSION, + DockerVersion: version.VERSION, Author: author, Config: config, Architecture: runtime.GOARCH, diff --git a/graph/graph_test.go b/graph/graph_test.go index 79c2d099a0..ed907440f1 100644 --- a/graph/graph_test.go +++ b/graph/graph_test.go @@ -9,10 +9,10 @@ import ( "testing" "time" - "github.com/docker/docker/autogen/dockerversion" "github.com/docker/docker/daemon/graphdriver" "github.com/docker/docker/image" "github.com/docker/docker/pkg/stringid" + "github.com/docker/docker/version" ) func TestMount(t *testing.T) { @@ -106,8 +106,8 @@ func TestGraphCreate(t *testing.T) { if img.Comment != "Testing" { t.Fatalf("Wrong comment: should be '%s', not '%s'", "Testing", img.Comment) } - if img.DockerVersion != dockerversion.VERSION { - t.Fatalf("Wrong docker_version: should be '%s', not '%s'", dockerversion.VERSION, img.DockerVersion) + if img.DockerVersion != version.VERSION { + t.Fatalf("Wrong docker_version: should be '%s', not '%s'", version.VERSION, img.DockerVersion) } images := graph.Map() if l := len(images); l != 1 { diff --git a/hack/make.sh b/hack/make.sh index c7318953b4..854121d17f 100755 --- a/hack/make.sh +++ b/hack/make.sh @@ -146,7 +146,7 @@ fi EXTLDFLAGS_STATIC='-static' # ORIG_BUILDFLAGS is necessary for the cross target which cannot always build # with options like -race. -ORIG_BUILDFLAGS=( -a -tags "netgo static_build sqlite_omit_load_extension $DOCKER_BUILDTAGS" -installsuffix netgo ) +ORIG_BUILDFLAGS=( -a -tags "autogen netgo static_build sqlite_omit_load_extension $DOCKER_BUILDTAGS" -installsuffix netgo ) # see https://github.com/golang/go/issues/9369#issuecomment-69864440 for why -installsuffix is necessary here BUILDFLAGS=( $BUILDFLAGS "${ORIG_BUILDFLAGS[@]}" ) # Test timeout. diff --git a/hack/make/.go-autogen b/hack/make/.go-autogen index 52e2f571d8..434976ad94 100644 --- a/hack/make/.go-autogen +++ b/hack/make/.go-autogen @@ -2,12 +2,14 @@ rm -rf autogen -mkdir -p autogen/dockerversion -cat > autogen/dockerversion/dockerversion.go < version/version_autogen.go <