From 690711b5840be388fb13fb72856de337bdf645c7 Mon Sep 17 00:00:00 2001 From: Alexandr Morozov Date: Tue, 17 Jun 2014 11:39:47 +0400 Subject: [PATCH] Move TestBuildOnBuildForbiddenMaintainerTrigger to integration-cli Docker-DCO-1.1-Signed-off-by: Alexandr Morozov (github: LK4D4) --- integration-cli/docker_cli_build_test.go | 17 +++++++++++++++++ integration/buildfile_test.go | 14 -------------- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/integration-cli/docker_cli_build_test.go b/integration-cli/docker_cli_build_test.go index f83c3fc8ca..95f73f7e6c 100644 --- a/integration-cli/docker_cli_build_test.go +++ b/integration-cli/docker_cli_build_test.go @@ -1341,3 +1341,20 @@ func TestBuildOnBuildForbiddenFrom(t *testing.T) { } logDone("build - onbuild forbidden from") } + +func TestBuildOnBuildForbiddenMaintainer(t *testing.T) { + name := "testbuildonbuildforbiddenmaintainer" + defer deleteImages(name) + _, err := buildImage(name, + `FROM busybox + ONBUILD MAINTAINER docker.io`, + true) + if err != nil { + if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") { + t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err) + } + } else { + t.Fatal("Error must not be nil") + } + logDone("build - onbuild forbidden maintainer") +} diff --git a/integration/buildfile_test.go b/integration/buildfile_test.go index ce1e7224e3..c5c1fb0363 100644 --- a/integration/buildfile_test.go +++ b/integration/buildfile_test.go @@ -413,20 +413,6 @@ func buildImage(context testContextTemplate, t *testing.T, eng *engine.Engine, u return image, err } -func TestBuildOnBuildForbiddenMaintainerTrigger(t *testing.T) { - _, err := buildImage(testContextTemplate{` - from {IMAGE} - onbuild maintainer test - `, - nil, nil, - }, - t, nil, true, - ) - if err == nil { - t.Fatal("Error should not be nil") - } -} - // gh #2446 func TestBuildAddToSymlinkDest(t *testing.T) { eng := NewTestEngine(t)